Skip to content

issue 2396 fix - add profile submenu and expand top level menu if use… #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

ya3ya6
Copy link
Contributor

@ya3ya6 ya3ya6 commented Jun 16, 2019

Issue 2396 fix

Description : add profile submenu and expand top level menu if user is logged in
Changes :

  • Profile submenu is added on both default and production config files.
  • User status is added to TopNavRef component attributes.

NOTE: This doesn't work without this pull request: topcoder-platform/navigation-component#20

Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CircleCI issues

@ya3ya6
Copy link
Contributor Author

ya3ya6 commented Jun 19, 2019

@luizrrodrigues

Pr updated.

Changes:

  • Removed "Payments" and "All projects" from account dropdown menu.
  • Changed The name of Level2 Menu From "Profile" To "Dashboard":

image

  • fixed CircleCI issue.

@luizrrodrigues
Copy link
Collaborator

@ya3ya6 Sorry, maybe some confusion here.

  • Dashboard
  • My Profile
  • Payments

These need be secondary menu of Work

@luizrrodrigues
Copy link
Collaborator

  • Work
    • Dashboard
    • My Profile
    • Payments
  • Compete
    • All challenges
    • Competi...

@ya3ya6
Copy link
Contributor Author

ya3ya6 commented Jun 19, 2019

  • Work

    • Dashboard
    • My Profile
    • Payments
  • Compete

    • All challenges
    • Competi...

oops. i don't think so. the request come from : #2396 (comment)

he said that we need a level 2 navigation. work is level 1 menu, Compete, Tracks, Community are level 2 menues(second level menues), "All challenges" and "competitive programming" and etc are level 3 menues. (this terminology of level 1 menu and level 2 (second level) menus are in source code.)

a level 2 (second level) menu under work means "a level 2 menu under work" just like "compete" and "tracks". you can see the Work is bolded in design, and when you click it it will expand (which means its parent of compete, tracks, community), and also in menu model its parent of compete and tracks and community (search "HEADER_MENU" on here to see the menu model: https://github.com/topcoder-platform/community-app/blob/feature-new-nav/config/default.js)
So menu is not structured as you said in this comment (work is a level 1 menu and its parent of compete and tracks which are level2. but in your structure work is not parent of compete and tracks).

adding a completely different menu inside a level 1 menu (work) is not compatible with "menu model" and also "design", and it needs alot of change in structure of menu.

I beleive that @vic-tian meant this, and i thought you meant this as well before.

It's ok if you insist that the menu should be like that, but It will be good if you can ask about it from @vic-tian who suggest this, cause i think you misunderstood him.

@luizrrodrigues
Copy link
Collaborator

I see, I'll get confirmation

@ya3ya6
Copy link
Contributor Author

ya3ya6 commented Jun 19, 2019

@luizrrodrigues
Thanks .

also i said terminology of level 1 and level 2 and level 3 menus are in source code , it's in here: https://github.com/topcoder-platform/navigation-component/blob/develop/src/components/TopNav/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants