-
Notifications
You must be signed in to change notification settings - Fork 212
issue 2396 fix - add profile submenu and expand top level menu if use… #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CircleCI issues
Pr updated. Changes:
|
@ya3ya6 Sorry, maybe some confusion here.
These need be secondary menu of Work |
|
oops. i don't think so. the request come from : #2396 (comment) he said that we need a level 2 navigation. work is level 1 menu, Compete, Tracks, Community are level 2 menues(second level menues), "All challenges" and "competitive programming" and etc are level 3 menues. (this terminology of level 1 menu and level 2 (second level) menus are in source code.) a level 2 (second level) menu under work means "a level 2 menu under work" just like "compete" and "tracks". you can see the Work is bolded in design, and when you click it it will expand (which means its parent of compete, tracks, community), and also in menu model its parent of compete and tracks and community (search "HEADER_MENU" on here to see the menu model: https://github.com/topcoder-platform/community-app/blob/feature-new-nav/config/default.js) adding a completely different menu inside a level 1 menu (work) is not compatible with "menu model" and also "design", and it needs alot of change in structure of menu. I beleive that @vic-tian meant this, and i thought you meant this as well before. It's ok if you insist that the menu should be like that, but It will be good if you can ask about it from @vic-tian who suggest this, cause i think you misunderstood him. |
I see, I'll get confirmation |
@luizrrodrigues also i said terminology of level 1 and level 2 and level 3 menus are in source code , it's in here: https://github.com/topcoder-platform/navigation-component/blob/develop/src/components/TopNav/index.js |
Issue 2396 fix
Description : add profile submenu and expand top level menu if user is logged in
Changes :
NOTE: This doesn't work without this pull request: topcoder-platform/navigation-component#20