Skip to content

$75 | New Nav - Need "default" navigation back to dashboard #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sushilshinde opened this issue Jun 3, 2019 · 48 comments
Closed

$75 | New Nav - Need "default" navigation back to dashboard #2396

sushilshinde opened this issue Jun 3, 2019 · 48 comments
Assignees
@luizrrodrigues
Labels
nav_Assigned nav_FixAccepted nav_Paid Navigation P2 Important (resolve within 3 days)

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 3, 2019 •
edited
Loading

Describe the bug

There is no way to go back to Dashboard

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://test-community-app.topcoder-dev.com/challenges or
    https://test-community-app.topcoder-dev.com/members/TonyJ or any other page
  2. There is no link to go back to Dashboard

Expected behavior
Member should be able to click and go back to dashboard from any page of the app.

Screenshots

back to dashboard

If 1 or 2 are the options, then they are not working right now

Desktop:

  • OS: Mac
  • Chrome
@Oanh-and-only-Oanh Oanh-and-only-Oanh added the P2 Important (resolve within 3 days) label Jun 3, 2019
@vic-tian
Copy link

vic-tian commented Jun 3, 2019

The Dashboard is displayed when the user clicks on Work and is logged in. If they're not logged in, the home page of the community website should be displayed instead.

Screen Shot 2019-06-03 at 10 08 10 AM

@Oanh-and-only-Oanh
Copy link

@ThomasKranitsas, the navigation menu should always be expanded once member is logged in.

@vic-tian
Copy link

vic-tian commented Jun 3, 2019

To accomodate the missing navigation options from the sidebar, let's introduce a second-level navigation that lists all current navigation items once the user is logged in. In the attachment above Dashboard/Challenges/History/Payments, etc., are in the sidebar. Instead, to accommodate the intermediate state let's use the secondary menu.

We should have a new secondary navigation with the following structure:

  • Dashboard
  • My Profile
  • Payments

We moved the Settings and Log Out as part of the standard user drop-down (people expect to find those options in the user drop-down.)
Screen Shot 2019-06-03 at 3 06 00 PM

@luizrrodrigues luizrrodrigues changed the title New Nav - Need "default" navigation back to dashboard $75 | New Nav - Need "default" navigation back to dashboard Jun 7, 2019
@applehit16
Copy link
Contributor

I can work on this one

@luizrrodrigues
Copy link
Collaborator

Assigned to @applehit16

@applehit16
Copy link
Contributor

I tried to understand the requirements

  1. the navigation menu should always be expanded once member is logged in.
    rather than
    image
    The "Work" should be expanded to left
    image
    @Oanh-and-only-Oanh

We should have a new secondary navigation with the following structure:
Dashboard
My Profile
Payments

@vic-tian Where are we having this secondary navigation? under "Work"? if we have dashboard as option of secondary navigation, then what's the behavior of clicking the logo and "Work"?

To accomodate the missing navigation options from the sidebar, let's introduce a second-level navigation that lists all current navigation items once the user is logged in. In the attachment above Dashboard/Challenges/History/Payments, etc., are in the sidebar. Instead, to accommodate the intermediate state let's use the secondary menu.

@vic-tian I don't see any sidebar in https://test-community-app.topcoder-dev.com/my-dashboard

We moved the Settings and Log Out as part of the standard user drop-down (people expect to find those options in the user drop-down.)

what's this to do with the old nav? in the new nav, payment is part of user dropdown
image

@vic-tian Sorry, I still don't quite understand what you are trying to express. Can you attach a mock up or something?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jun 9, 2019 •
edited
Loading

@applehit16

  1. Yes

  2. Yes, secondary navigation under Work.
    When clicking in Work, Dashboard will be selected by default. (Like when clicking in Complete, All challenges selected by default)
    When clicking in the logo if the user is logged when to go Dashboard.

  3. (and 4) @Oanh-and-only-Oanh @vic-tian Please confirm if we need Payments in the dropdown menu and Work secondary menu.

@nithyaasworld nithyaasworld mentioned this issue Jun 10, 2019
Closed
@luizrrodrigues luizrrodrigues mentioned this issue Jun 11, 2019
Open
@luizrrodrigues
Copy link
Collaborator

@applehit16 Any status on this?

@applehit16
Copy link
Contributor

applehit16 commented Jun 12, 2019 via email

@luizrrodrigues
Copy link
Collaborator

@applehit16 Oh sorry. I'll request confirmation again.

@luizrrodrigues
Copy link
Collaborator

@vic-tian @Oanh-and-only-Oanh Please can confirm item 3 and 4: #2396 (comment)

@applehit16
Copy link
Contributor

Things keep coming, feel free to reassign from me, sorry for the delay...

@luizrrodrigues
Copy link
Collaborator

@applehit16 Okay, no problem.

@luizrrodrigues
Copy link
Collaborator

@ya3ya6 Looks good, some requests:

  • Please remove Payments from dropdown menu
  • Remove All projects from dropdown menu

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019

@luizrrodrigues Thanks for review. i'll add requirements and fix the tests. And a question: Should i change the name of this level 2 menu from "Profile" to "Dashboard"?

@luizrrodrigues
Copy link
Collaborator

Level 2 need be:

  • Dashboard
  • My Profile
  • Payments

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019 •
edited
Loading

@luizrrodrigues Thanks. but i meant the name of level2 itself. i changed it to "Dashboard", you can see it on updated pull request : #2629

@luizrrodrigues
Copy link
Collaborator

I give feedback in #2629

@ya3ya6 ya3ya6 mentioned this issue Jun 19, 2019
Closed
@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Please let me know if new secondary menu placement looks right:

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019

@Oanh-and-only-Oanh
To complete the comment of @luizrrodrigues , let me explain the bahaviour :
When user clicks on "work" , Dashboard (first sub menu) will be selected. and the selected item will be "Dashboard". So work is not selectable, work button usage is expanding the work menu when user is not logged in, and also selecting the dashboard. here is a video of behaviour (in this video the name of it submenu is Profile, instead of Dashboard (it's prev version)):
Video_19-06-19_17-29-58.zip

@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, DASHBOARD should not be in top level nav. It's is only in secondary nav level under WORK. It should be the default page when logged-in members click WORK.

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Thanks.

@ya3ya6 Need follow structure shared here:
#2629 (comment)

@vic-tian
Copy link

This is not according to the design. Let's fix the intended behavior of the navigation:

  • When a member is logged into the system, the WORK (Should be named COMMUNITY - @Oanh-and-only-Oanh please confirm) item is selected and the new secondary menu is displayed.

Screen Shot 2019-06-19 at 7 13 48 AM

  • When a member is not logged into the system (anonymous, public viewer), the WORK (COMMUNITY) navigation item should load the public page. This behavior is very similar to what GitHub experience is.

Screen Shot 2019-06-19 at 7 19 44 AM

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jun 19, 2019 •
edited
Loading

@vic-tian Change Work to Community will be fixed here: #2640

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019

@luizrrodrigues Thanks.

Sorry for missunderstanding and causing delay.

  1. (+ @vic-tian) what about mobile? can you share a picture about how mobile should behave? cause there is no space under work for mobile.

  2. is any force to reuse level 3 menu , or it can be separate? i mean, this secondary menu should be similar to other third level menus, but its parent is not a level 2 menu, and it's probably not reusable.

  3. When user clicks the Work button, It should expand the menu If user is not logged in, and if it's expanded already, it should select this secondary menu?

And finally, It's completely another approach and i should start from zero, plus it's not easy. it takes about 2/3 days, is it ok? if not, please reassign me from this, because i don't want to cause daley to this anymore. (and sorry again for this)

@luizrrodrigues
Copy link
Collaborator

  1. If not logged user, when click in Work will expand and load Community Home page.

@vic-tian
Copy link

Mobile interaction is focused on presenting the option of the main page/section of Community or Business as "Home Page", the secondary menu is displayed on the top of the page as drop-down. Check https://marvelapp.com/1dgiejg6/screen/54473672 or https://marvelapp.com/89423f8/screen/54595272
image
Screen Shot 2019-06-19 at 9 04 21 AM

@luizrrodrigues
Copy link
Collaborator

@ya3ya6 you think will able to complete this until tomorrow? I see you progress effort and progress here, we need done ASAP to smoke test on Friday.

Please let me know.

Thanks.

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019

@luizrrodrigues Thanks. I think i can do it in about 18 hours from now, is it ok?

@luizrrodrigues
Copy link
Collaborator

@ya3ya6 Yes, keep me updated and feel free to send PR to pre check.

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 19, 2019

@luizrrodrigues ok, i will. thanks.

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 20, 2019

@luizrrodrigues Hi. The code is ready But there is some conflicts on Commits, so please let me fix pull request conflicts and i'll let you know where pull request is ready.

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 20, 2019 •
edited
Loading

@luizrrodrigues
Sorry for delay.
These are new pull requests :
topcoder-platform/navigation-component#28
#2649
(Previous pull requests are invalid, i deleted the privious repository and created a new one. please remove them)

@luizrrodrigues
Copy link
Collaborator

@ya3ya6 I found an issue in Mobile, looks like Desktop secondary menu showing.

image

@ya3ya6
Copy link
Contributor

ya3ya6 commented Jun 21, 2019 •
edited
Loading

@sushilshinde sorry for not noticing that. fixed and pr updated: topcoder-platform/navigation-component#28

luizrrodrigues added a commit that referenced this issue Jun 21, 2019
@luizrrodrigues
Merge pull request #2649 from ya3ya6/feature-new-nav
640e2ba 
Fix Issue #2396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizrrodrigues luizrrodrigues

Labels
nav_Assigned nav_FixAccepted nav_Paid Navigation P2 Important (resolve within 3 days)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sushilshinde @ThomasKranitsas @luizrrodrigues @vic-tian @ya3ya6 @Oanh-and-only-Oanh @applehit16