Skip to content

Past Challenges must be accessible by searching with the date filter #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Sep 21, 2020 · 17 comments
Closed

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 21, 2020

How do you access past challenges?

Exit:
Past Challenges must be accessible by searching with the date filter

@SathyaJayabal SathyaJayabal added P1 Urgent (resolve within 24 hours) listing:re-implementation labels Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 21, 2020
@Oanh-and-only-Oanh
Copy link

@SathyaJayabal, Past challenges should be searched view filter with date rage

@LieutenantRoger
Copy link
Collaborator

@SathyaJayabal Correct, the past challenges bucket is removed, please close this ticket. @Oanh-and-only-Oanh

@Oanh-and-only-Oanh
Copy link

@SathyaJayabal please verify that Past challenges should be searched view filter with date rage before closing. I was not able to do so... @LieutenantRoger

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Sep 21, 2020

@LieutenantRoger, but we are not able to search past challenges using keyword search nor the date filter
Screenshot 2020-09-21 at 10 12 15 PM

@LieutenantRoger
Copy link
Collaborator

@SathyaJayabal

Please change the ticket description about what the problem, instead of posting a snapshot in the conversation.

The main description apparently a false one.

@SathyaJayabal SathyaJayabal changed the title Past Challenges Past Challenges must be accessible by searching with the date filter Sep 23, 2020
LieutenantRoger added a commit that referenced this issue Sep 23, 2020
@LieutenantRoger
Copy link
Collaborator

PR is here: #4993

@luizrrodrigues
Copy link
Collaborator

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal @LieutenantRoger

This looks like a issue with API, if check same range Prod also will return nothing:
https://www.topcoder.com/challenges?filter[startDate]=2018-07-01T15%3A00%3A00.000Z&filter[endDate]=2018-10-31T15%3A00%3A00.000Z&bucket=past


@LieutenantRoger I see the changes and is a valid fix, because was missing & between params. So I'll merge the code.


@LieutenantRoger But found a new issue, if refresh the page or try access directly (https://test-community-app.topcoder-dev.com/challenges?startDateStart=2020-08-01T15:00:00.000Z&endDateEnd=2020-08-31T15:00:00.000Z) filter not applied.

@SathyaJayabal Can you create a new issue to this one or maybe we can track here.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , I think #4981 will take care of the new issue. Please confirm.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Oh, yep.

@SathyaJayabal SathyaJayabal added the Need clarification Need clarification to proceed fixing the issue further label Sep 24, 2020
@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde @luizrrodrigues , as discussed, we are waiting on clarification on how to implement this and where to display the past challenges

@ThomasKranitsas
Copy link
Contributor

You can use the endDateEnd query parameter to fetch past challenges and set it to the current date. Additionally, you can also use status=Completed to only fetch the completed past challenges.

Example API call: http://api.topcoder.com/v5/challenges?endDateEnd=2020-09-24T00:00:00Z

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Any status in this one?

Please check: #4972 (comment)

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger
Copy link
Collaborator

Hi @luizrrodrigues saw a challenge is launched for this issue. Yes, I used status=Active by default which causes this.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues @sushilshinde @Oanh-and-only-Oanh , This looks good.
Screenshot 2020-10-08 at 5 54 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants