Skip to content

Past Challenges (MMs) are returning empty #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Mar 14, 2020 · 14 comments
Closed

Past Challenges (MMs) are returning empty #4112

sushilshinde opened this issue Mar 14, 2020 · 14 comments
Assignees

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented Mar 14, 2020

Steps to reproduce : 1-4

Topcoder Challenges 2020-03-14 09-40-13

Problem # 1

Calls : https://api.topcoder.com/v4/challenges/?filter=status%3DCOMPLETED&limit=50&offset=750
doesn't include filter Data Science

Problem # 2

UI is not showing challenges even though calls are returning the response.

@sushilshinde sushilshinde added P1 Urgent (resolve within 24 hours) Challenge Listing labels Mar 14, 2020
@sushilshinde
Copy link
Collaborator Author

FYI @dmessing

@dmessing
Copy link
Contributor

Maybe v5 helps here?

@LieutenantRoger
Copy link
Collaborator

Hi @dmessing

We will need to discuss about how to resolve this.

Some background info: in order to resolve this ticket: #3610 we made a configuration time (currently, 30 seconds)

So if we don't find a result with the filters applied within the configured time above, we would stop continuing to request data, and show user with the No challenges found in Past Challenge

@SathyaJayabal
Copy link
Collaborator

@sushilshinde , this issue is not just with data science track. When we select a date range a few years in the past, the search times out (due to the configured 30 secs).

Screenshot 2020-05-27 at 11 13 39 AM

Screenshot 2020-05-27 at 11 14 45 AM

Screenshot 2020-05-27 at 11 19 31 AM

@luizrrodrigues luizrrodrigues changed the title Past Challenges (MMs) are returning empty [$50] Past Challenges (MMs) are returning empty Sep 3, 2020
@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Please let me know if you'll able to work on this one or if we can open for pickup.

Thanks.

@Oanh-and-only-Oanh
Copy link

@LieutenantRoger, will this issue be resolved once the new listing performance is upgraded?

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Sep 8, 2020

Yes, I think so, as long as the V5 API can return past MMs challenges.

I haven't check the detail, the corresponding requirement seems changed, and the past challenges bucket looks should be removed

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$50] Past Challenges (MMs) are returning empty Past Challenges (MMs) are returning empty Sep 8, 2020
@sushilshinde
Copy link
Collaborator Author

Yes, I think so, as long as the V5 API can return past MMs challenges.

I haven't check the detail, the corresponding requirement seems changed, and the past challenges bucket looks should be removed

@Oanh-and-only-Oanh is this issue irrelevant now?

@sushilshinde sushilshinde added the Need clarification Need clarification to proceed fixing the issue further label Sep 15, 2020
@Oanh-and-only-Oanh
Copy link

I don't want to close this yet until new listing performance is upgraded and this issue is fixed along with it.

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the Need clarification Need clarification to proceed fixing the issue further label Sep 15, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed this from the By 9/17/2020 milestone Sep 16, 2020
@Oanh-and-only-Oanh
Copy link

@SathyaJayabal @sandhiyakavi, please verify if issue is resolved after new listing implementation. thank you.

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: By 9/24/2020, Release by 10/1/2020 Sep 21, 2020
@LieutenantRoger
Copy link
Collaborator

This ticket is only for verifying: so please verify it along with this ticket: #4972

@SathyaJayabal
Copy link
Collaborator

Will verify along with #4972

@SathyaJayabal
Copy link
Collaborator

verified on staging
Screenshot 2020-10-08 at 8 57 24 PM

@sandhiyakavi
Copy link
Collaborator

Verified on Prod Env.

image

@sandhiyakavi sandhiyakavi added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants