Skip to content

URL not updating based on filter settings #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Sep 21, 2020 · 34 comments
Closed

URL not updating based on filter settings #4981

Oanh-and-only-Oanh opened this issue Sep 21, 2020 · 34 comments
Labels
Challenge Listing listing:re-implementation P1 Urgent (resolve within 24 hours) QA Pass in Staging

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 21, 2020 •
edited
Loading

Bug:
The URL remains https://staging-community-app.topcoder.com/challenges? regardless of filter settings

How to reproduce the bug:

  1. got to https://staging-community-app.topcoder.com/challenges?
  2. turn off track filters
  3. see that the URL remains unchanged
    Observe unchanging URLs in screenshots even though filters have changed
    image
    image
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/1/2020 milestone Sep 21, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P2 Important (resolve within 3 days) and removed P1 Urgent (resolve within 24 hours) labels Sep 22, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title URL not updating based on filter settings [$65] URL not updating based on filter settings Sep 22, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143200 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/feature-refactor-challengelist
https://github.com/topcoder-platform/topcoder-react-lib/tree/feature-refactor-challengelist

run npm run test before PR

@narekcat narekcat self-assigned this Sep 23, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143200 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@SathyaJayabal SathyaJayabal mentioned this issue Sep 24, 2020
Closed
@Oanh-and-only-Oanh
Copy link
Author

@narekcat, please provide update in next few hours.

@narekcat narekcat removed their assignment Sep 28, 2020
@rashmi73 rashmi73 self-assigned this Sep 29, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143200 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@Oanh-and-only-Oanh Oanh-and-only-Oanh modified the milestones: Release by 10/1/2020, by 10/15/2020 Sep 29, 2020
@Oanh-and-only-Oanh
Copy link
Author

hi @rashmi73, please update with status.

@rashmi73
Copy link
Contributor

rashmi73 commented Oct 1, 2020

@Oanh-and-only-Oanh its working fine at https://staging-community-app.topcoder.com/challenges and urls are changing on filtering tracks.
can you please confirm?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 1, 2020 •
edited
Loading

@rashmi73 Currently Stag env running develop branch

But release already over and I'll deploy feature-refactor-challengelist back to Stag env.

Please check again in 20min

@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji in Challenge Details, if click in challenge type or tag, API called with wrong param:

image

@Oanh-and-only-Oanh Oanh-and-only-Oanh added Must-fix-before-listing-release P1 Urgent (resolve within 24 hours) and removed P2 Important (resolve within 3 days) labels Oct 8, 2020
@PrakashDurlabhji
Copy link
Contributor

@luizrrodrigues what is the expected to be sent?

  1. tracks[]: dev should not be sent correct?
  2. sent value should be tracks object like tracks: {Dev: true, Des: true} correct?

@PrakashDurlabhji
Copy link
Contributor

@Oanh-and-only-Oanh Kindly do not launch this as F2F, as its almost completed.

@luizrrodrigues luizrrodrigues mentioned this issue Oct 8, 2020
Closed
@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji What was done in challenge listing page is correct and working well.

But if click in tag in Details page:

image

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 8, 2020 •
edited
Loading

image

image

@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji ☝️

@luizrrodrigues
Copy link
Collaborator

Moving this one to F2F

@luizrrodrigues
Copy link
Collaborator

F2F: https://www.topcoder.com/challenges/5bc4b0ac-aa74-4ac1-9c7d-db4f192c87e3

@luizrrodrigues luizrrodrigues changed the title [$70] URL not updating based on filter settings URL not updating based on filter settings Oct 8, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging
Screenshot 2020-10-09 at 8 02 52 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Challenge Listing listing:re-implementation P1 Urgent (resolve within 24 hours) QA Pass in Staging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@LieutenantRoger @luizrrodrigues @narekcat @PrakashDurlabhji @rashmi73 @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal