Skip to content

[$50] Recommended Articles section is missing in challenge details #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Aug 17, 2020 · 15 comments
Closed

[$50] Recommended Articles section is missing in challenge details #4765

SathyaJayabal opened this issue Aug 17, 2020 · 15 comments
Assignees
@cagdas001
Labels
Beta Env Environment Challenge Details Screen P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-integration-codefreeze v5-intgration-sub-code
Milestone
v1.1.4

Comments

@SathyaJayabal
Copy link
Collaborator

Recommended Articles section is missing in challenge details
example:
https://beta-community-app.topcoder.com/challenges/93bef7e6-a99e-479b-95bf-464b2dffc7b5
https://www.topcoder.com/challenges/30136864

Screenshot 2020-08-17 at 5 26 46 PM
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P3 Normal (resolved within 7 days) and removed P2 Important (resolve within 3 days) labels Aug 17, 2020
@luizrrodrigues
Copy link
Collaborator

Another example:
https://beta-community-app.topcoder.com/challenges/30139563
https://www.topcoder.com/challenges/6d79cf9c-d751-4f86-ab9d-10a34c1ef790

@luizrrodrigues luizrrodrigues changed the title Recommended Articles section is missing in challenge details [$50] Recommended Articles section is missing in challenge details Sep 3, 2020
@crazyk07
Copy link

crazyk07 commented Sep 3, 2020

Contest https://www.topcoder.com/challenges/30140434 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Sep 3, 2020 •
edited by luizrrodrigues
Loading

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-v1.3
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-v1.3

run npm run test before PR

1 similar comment
@SathyaJayabal
Copy link
Collaborator Author

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-v1.3
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-v1.3

run npm run test before PR

@cagdas001 cagdas001 self-assigned this Sep 3, 2020
@crazyk07
Copy link

crazyk07 commented Sep 3, 2020

Contest https://www.topcoder.com/challenges/30140434 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

@cagdas001 cagdas001 mentioned this issue Sep 3, 2020
Merged
@cagdas001
Copy link
Collaborator

PR: #4855

It was showing the articles for only Design track. See here: https://github.com/topcoder-platform/community-app/pull/4855/files#diff-62e47fd2e59644bd99702dbf0778ae50L247

I guess we have no restriction to show articles, so simply removed this condition. It will show articles for all tracks

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh @SathyaJayabal Please confirm about show related articles for all tracks.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues @cagdas001 , Thats odd, we do not show articles only for design track, as related articles are based on tech tags and design challenges do not have tech tags.

@cagdas001
Copy link
Collaborator

@luizrrodrigues @cagdas001 , Thats odd, we do not show articles only for design track, as related articles are based on tech tags and design challenges do not have tech tags.

So it should be shown for ALL (incl. Task, F2F etc) except for Design track?

@SathyaJayabal
Copy link
Collaborator Author

@cagdas001 ,
185d342#diff-62e47fd2e59644bd99702dbf0778ae50
it should be not equal to design track, when the track updates were made, there was typo.

cagdas001 added a commit to cagdas001/community-app that referenced this issue Sep 3, 2020
@cagdas001
fix(challenge-detail): condition for showing thrive articles
4b2bcb7 
Fix a typo in if condition used to show thrive articles.
  - It was showing them only for the Design track.
  - Articles will be shown for all tracks except for the Design track.

References topcoder-platform#4765
@cagdas001
Copy link
Collaborator

Updated the PR: #4855

luizrrodrigues added a commit that referenced this issue Sep 4, 2020
@luizrrodrigues
Deploy milestone-v1.3 to Dev and Staging
7ac1ae3 
Issues: #4752 #4765 #4755 #4758
@sandhiyakavi
Copy link
Collaborator

Tested in Staging Environment.Working as expected.

image
image

Design Challenge:

image

@luizrrodrigues luizrrodrigues mentioned this issue Sep 8, 2020
Merged
@SathyaJayabal SathyaJayabal modified the milestones: By 9/17/2020, v1.1.4 Sep 8, 2020
sushilshinde added a commit that referenced this issue Sep 8, 2020
@sushilshinde
fix: smoke release
9a21345 
#4844, #4760, #4752, #4765, #4755, #4756 and #4758
@SathyaJayabal
Copy link
Collaborator Author

verified on staging (develop)
Screenshot 2020-09-08 at 5 26 03 PM

This was referenced Sep 8, 2020
Merged
Merged
sushilshinde added a commit that referenced this issue Sep 8, 2020
@sushilshinde
fix: prod release 2020-09-08 (v1.1.4)
0318d13 
Release 2020-09-08 (v1.1.4)

#4844, #4760, #4752, #4765, #4755, #4756 and #4758 #4683
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 8, 2020
@SathyaJayabal
Copy link
Collaborator Author

tested on prod
Screenshot 2020-09-08 at 7 25 04 PM

@crazyk07
Copy link

crazyk07 commented Sep 8, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30140434

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagdas001 cagdas001

Labels
Beta Env Environment Challenge Details Screen P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-integration-codefreeze v5-intgration-sub-code
Projects
None yet
Milestone
v1.1.4
Development

No branches or pull requests
6 participants
@luizrrodrigues @cagdas001 @crazyk07 @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal