Skip to content

[$40] Marathon match "My Submissions" tab "Add Submission" button must be enabled #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Aug 14, 2020 · 15 comments
Closed

[$40] Marathon match "My Submissions" tab "Add Submission" button must be enabled #4756

SathyaJayabal opened this issue Aug 14, 2020 · 15 comments
Assignees
@narekcat
Labels
Beta Env Environment Challenge Details Screen P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-integration-codefreeze v5-intgration-sub-code
Milestone
v1.1.4

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Aug 14, 2020 •
edited by luizrrodrigues
Loading

Marathon match "My Submissions" tab "Add Submission" button must be enabled when the submission phase is open

example:
https://www.topcoder.com/challenges/b702e3e9-94f2-456d-b33a-f14db1577877?tab=my_submissions
https://beta-community-app.topcoder.com/challenges/30136851?tab=my_submissions
Screenshot 2020-08-14 at 6 50 37 PM
Screenshot 2020-08-14 at 6 51 33 PM
@Oanh-and-only-Oanh
Copy link

@SathyaJayabal, but members are still able to submit using the Main Submit button, correct?

@SathyaJayabal
Copy link
Collaborator Author

yes, they can. and also from Submission tab "Add Submission" button

@luizrrodrigues luizrrodrigues changed the title Marathon match "My Submissions" tab "Add Submission" button must be enabled [$40] Marathon match "My Submissions" tab "Add Submission" button must be enabled Sep 3, 2020
@crazyk07
Copy link

crazyk07 commented Sep 3, 2020

Contest https://www.topcoder.com/challenges/30140428 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Sep 3, 2020 •
edited
Loading

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/milestone-v1.3
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-v1.3

run npm run test before PR

@narekcat narekcat self-assigned this Sep 3, 2020
@crazyk07
Copy link

crazyk07 commented Sep 3, 2020

Contest https://www.topcoder.com/challenges/30140428 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@narekcat Thanks for join on this one.

Please use these branches:
https://github.com/topcoder-platform/community-app/tree/milestone-v1.3
https://github.com/topcoder-platform/topcoder-react-lib/tree/milestone-v1.3

@cagdas001 cagdas001 mentioned this issue Sep 3, 2020
Closed
@narekcat
Copy link
Contributor

narekcat commented Sep 3, 2020

@luizrrodrigues Ok.

@narekcat
Copy link
Contributor

narekcat commented Sep 3, 2020 •
edited
Loading

@luizrrodrigues Must "Add Submissions" button be enabled, when challenge is legacy Marathon match ?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Sep 3, 2020 •
edited
Loading

@narekcat Need enable button if the submission phase is open. Legacy MMs are old challenges so this phase already closed.

@narekcat
Copy link
Contributor

narekcat commented Sep 3, 2020

@luizrrodrigues Ok.

narekcat added a commit to narekcat/community-app that referenced this issue Sep 3, 2020
@narekcat
fix: for issue topcoder-platform#4756
0e221c8
@narekcat
Copy link
Contributor

narekcat commented Sep 3, 2020

@SathyaJayabal @luizrrodrigues I have fixed this issue, please see pull request #4856.

luizrrodrigues added a commit that referenced this issue Sep 7, 2020
@luizrrodrigues
Merge pull request #4856 from narekcat/issue-4756
221473f 
fix: for issue #4756
@SathyaJayabal
Copy link
Collaborator Author

verified on staging
Screenshot 2020-09-07 at 8 59 31 PM

@luizrrodrigues luizrrodrigues mentioned this issue Sep 8, 2020
Merged
@SathyaJayabal SathyaJayabal modified the milestones: By 9/17/2020, v1.1.4 Sep 8, 2020
sushilshinde added a commit that referenced this issue Sep 8, 2020
@sushilshinde
fix: smoke release
9a21345 
#4844, #4760, #4752, #4765, #4755, #4756 and #4758
@SathyaJayabal
Copy link
Collaborator Author

verified on staging
Screenshot 2020-09-08 at 5 31 37 PM

This was referenced Sep 8, 2020
Merged
Merged
sushilshinde added a commit that referenced this issue Sep 8, 2020
@sushilshinde
fix: prod release 2020-09-08 (v1.1.4)
0318d13 
Release 2020-09-08 (v1.1.4)

#4844, #4760, #4752, #4765, #4755, #4756 and #4758 #4683
@SathyaJayabal
Copy link
Collaborator Author

tested on prod
Screenshot 2020-09-08 at 7 33 59 PM

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed QA Pass in Staging labels Sep 8, 2020
@crazyk07
Copy link

crazyk07 commented Sep 8, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30140428

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narekcat narekcat

Labels
Beta Env Environment Challenge Details Screen P3 Normal (resolved within 7 days) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid v5-integration-codefreeze v5-intgration-sub-code
Projects
None yet
Milestone
v1.1.4
Development

No branches or pull requests
5 participants
@luizrrodrigues @narekcat @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal