[$75] Marathon Leaderboard Showing 100 for failed submission

[ajefts]

Describe the bug
In certain cases a MM submission is failing to run. The Virus scan returns 100, but the next review doesn't succeed. The leaderboard is displaying 100 as their submission score, which is incorrect. It should be marked as a fail on the leaderboard.

If you check the API calls that get submissions (i.e. https://api.topcoder.com/v5/submissions?challengeId=30120970&page=1&perPage=500), you'll see a review array. The app needs to check the typeID to determine the review type. The scores posted on the leaderboard should not be the typeID that maps to AV Scan. You'll notice some submissions have 1 review record while others have multiple review records. The app needs to inspect them to make sure it's the correct one to display.

See screenshot for an example.

To Reproduce

Steps to reproduce the behavior:

1. Go to https://www.topcoder.com/challenges/30120970?tab=submissions
2. Click on the submissions with 100
3. Inspect the submission API data

Screenshots

https://www.topcoder.com/direct/customerProjectsAjaxAction

[ajefts]

cc: @dushyantb @cwdcwd

[ajefts]

@Oanh-and-only-Oanh @sushilshinde Can we get a quick fix in for this one? It's causing a lot of problems on live marathon matches.

[cwdcwd]

the community app should look up the reviewType of Virus Scan at the /v5/reviewTypes endpoint and ignore all reviews of that type's Id

[bountyC0d3r]

{
    "name": "Virus Scan",
    "id": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
    "isActive": true
}

This is the Virus Scan reviewType in production, which we should filter out.

[cwdcwd]

Note, please don't just hard code that Id in to solve this

[crazyk07]

Contest https://www.topcoder.com/challenges/30124030 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30124030 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

[luizrrodrigues]

Hey @narekcat, checking progress here, how things are going?

Thanks

[narekcat]

@luizrrodrigues I am working on it. I will finish it in next 6 hours.

[narekcat]

@luizrrodrigues - I tried to reproduce this bug, but I couldn't find an example of submission that succeed virus scan, but failed next review and in submissions list it's score is 100. Yesterday I could reproduce this bug, but today its working as expected. I also checked some other challenge submissions, but couldn't reproduce the bug.

[luizrrodrigues]

@narekcat Okay, I'll recheck and back to you shortly.

[luizrrodrigues]

@narekcat I'm able to reproduce the issue in this challenge:
https://www.topcoder.com/challenges/30123519?tab=submissions

[narekcat]

@luizrrodrigues Ok, I am already working on this issue.

[narekcat]

@luizrrodrigues I have debugged application and found out that it already ignores all reviews of Virus Scan (see https://github.com/topcoder-platform/topcoder-react-lib/blob/develop/src/utils/submission.js#L137). But in production it uses development typeId (see https://github.com/topcoder-platform/topcoder-react-lib/blob/develop/config/development.json#L2)

If we change configs then it will work as expected (see https://github.com/topcoder-platform/topcoder-react-lib/blob/develop/config/production.json#L2) I have tested and it works correctly in my local. Actually I can get reviewType of Virus Scan at the /v5/reviewTypes endpoint and ignore all reviews of that type's Id. But then application needs to do additional request every time. What I need to do ? One more thing, when submission has only one review and it is Virus Scan then it shows empty field under provisional score.

[luizrrodrigues]

@narekcat Cool, nice catch. Currently, we have an issue with topcoder-react-lib config file, the Prod server using development config file, we already have a ticket to this issue.

I'll do some checks today and back to you.

[narekcat]

@luizrrodrigues Ok.

[luizrrodrigues]

@Oanh-and-only-Oanh @narekcat
The ticket to track the issue with topcoder-react-lib using Develop config in Production is this one: #4345

Already take a look and probably found the issue, I'll do some local test right now and give feedback on the ticket.

[Oanh-and-only-Oanh]

@luizrrodrigues @narekcat, we need to resolve this asap. Please put your attention to this. thanks

[luizrrodrigues]

@Oanh-and-only-Oanh I'm checking fix to #4345 right now.

[narekcat]

@luizrrodrigues @Oanh-and-only-Oanh Ok.

[luizrrodrigues]

@Oanh-and-only-Oanh @narekcat

Issue found, please check: #4345 (comment)

I'll prepare the branch run QA.

[Oanh-and-only-Oanh]

Great job @luizrrodrigues! Thanks

[Oanh-and-only-Oanh]

Let’s aim to close this ASAP. Tony and Glenn will be very happy know.

[luizrrodrigues]

@Oanh-and-only-Oanh @ajefts @cwdcwd

After fix topcoder-react-lib config file, fix showing AV SCAN as 100 scores in Prod, but checking this with Dev env looks like still showing 100 as score, in submissions return (only in Dev env) showing an additional review with id d96d5f17-5884-47b8-bfea-bddf066e451f, this id not present in return of v5/reviewTypes:

[
    {
        "name": "test-for-create",
        "id": "ff5742d6-22bf-4734-b632-add6641078be",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "80d25e94-8b3a-4fd7-9c10-971a0310ddc9",
        "isActive": true
    },
    {
        "name": "test-for-put",
        "id": "16234ad9-800e-47b1-a3e0-0b2116f93b55",
        "isActive": false
    },
    {
        "name": "Iterative Review",
        "id": "c611be23-66b6-4fd3-9dce-4aa49bb0771f",
        "isActive": true
    },
    {
        "name": "Review Two",
        "id": "5b010294-475f-4e26-bb7a-64bcca4ea26e",
        "isActive": true
    },
    {
        "name": "Review Two",
        "id": "61dbb928-0038-415b-943d-7edce8c47869",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "f56c9590-52da-4aeb-aa46-cc4c3e0aa122",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "da9c7351-ec86-4b59-8b4d-7baaa7be38ad",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "f04ec511-96a8-4c89-adf9-022d51c37ae7",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "5677c40c-931c-4898-a2a8-948e6f46c297",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "47422e1d-3519-4cd9-88cc-027d69f1fcfb",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "21819fc2-2863-4d6f-90c7-20b769d76986",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "f394252c-940e-446c-b377-b960ff296652",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "50b917df-5b81-4081-8e20-7fc8a6aabe54",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "20d7cbcf-1ea7-40c8-9d5e-6909b2e293c0",
        "isActive": true
    },
    {
        "name": "AV Scan",
        "id": "6da98d0f-e663-4539-8507-cd6c9e0e56d8",
        "isActive": true
    },
    {
        "name": "test-for-create",
        "id": "9dc204f7-9b6b-4939-a543-12764764dccf",
        "isActive": true
    },
    {
        "name": "Iterative Review",
        "id": "d1386ebe-a6b3-4b2b-8036-04b7285b71e6",
        "isActive": true
    },
    {
        "name": "test-for-put",
        "id": "8e3e7c78-ceb6-4be1-b636-71f070764ee7",
        "isActive": false
    },
    {
        "name": "Iterative Review",
        "id": "884339ec-2a7a-46a0-a035-03e64a879e77",
        "isActive": true
    }
]

[luizrrodrigues]

[luizrrodrigues]

@SathyaJayabal This one ready to QA in Beta env.

You can check with this challenge:
https://beta-community-app.topcoder.com/challenges/30123533?tab=submissions
https://www.topcoder.com/challenges/30123533?tab=submissions

[SathyaJayabal]

@luizrrodrigues , verified on beta
The virus scan review score is not displayed.

[SathyaJayabal]

@luizrrodrigues, we should also ignore the unknown review type, because this will cause the issue to come back when the submissions processor is released (since submissions processor is on dev env and we still see the issue in dev)

ref:
https://topcoder.slack.com/archives/C53KB3T7Z/p1589196295018700?thread_ts=1588990129.482000&cid=C53KB3T7Z

cc @Oanh-and-only-Oanh @mtwomey

[Oanh-and-only-Oanh]

We’ll verify again in PROD since it shouldn’t be a problem there.

On Mon, May 11, 2020 at 9:08 AM SathyaJayabal ***@***.***> wrote: @luizrrodrigues <https://github.com/luizrrodrigues>, we should also ignore the unknown review type, because this will cause the issue to come back when the submissions processor is released (since submissions processor is on dev env and we still see the issue in dev) cc @Oanh-and-only-Oanh <https://github.com/Oanh-and-only-Oanh> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKVPTTKJRAX4TIUQISWGC3RRAPHVANCNFSM4MXEPS6A> .

-- <https://www.topcoder.com/> *Oanh Tran* Product Manager, Community App 732-353-9457 www.topcoder.com | @topcoder <http://twitter.com/topcoder>

[SathyaJayabal]

Verified on beta (develop branch)

[sandhiyakavi]

verified in Production.Working as Expected.

[crazyk07]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

[crazyk07]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30124030

This is an automated message for crazyk via Topcoder X