Skip to content

topcoder-react-lib using Development config file in Production #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luizrrodrigues opened this issue May 5, 2020 · 6 comments
Closed

topcoder-react-lib using Development config file in Production #4345

luizrrodrigues opened this issue May 5, 2020 · 6 comments
Assignees
@luizrrodrigues
Labels
P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass
Milestone
v0.32.4

Comments

@luizrrodrigues
Copy link
Collaborator

@sushilshinde This ticket to track the issue we discuss before.
@luizrrodrigues luizrrodrigues self-assigned this May 5, 2020
@SathyaJayabal SathyaJayabal mentioned this issue May 6, 2020
Closed
@luizrrodrigues luizrrodrigues mentioned this issue May 8, 2020
Closed
luizrrodrigues referenced this issue in topcoder-platform/topcoder-react-lib May 8, 2020
@LieutenantRoger
merge with develop branch
2106478
@luizrrodrigues
Copy link
Collaborator Author

@Oanh-and-only-Oanh Issue found.

The origin of the issue was in this commit: topcoder-platform/topcoder-react-lib@2106478

This removed NODE_ENV= from package.json

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , how de we verify this issue. Will verification of #4336 cover this one too?

@luizrrodrigues
Copy link
Collaborator Author

Yes, this one fix #4336 issue.

To verify, just check the AV Scan ID, topcoder-react-lib have a configuration file to dev and prod env.

topcoder-react-lib

config/development.json
config/production.json

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented May 11, 2020 •
edited
Loading

verified on beta, @luizrrodrigues
Screenshot 2020-05-11 at 11 00 21 AM

Screenshot 2020-05-11 at 4 46 25 PM

@luizrrodrigues luizrrodrigues mentioned this issue May 12, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

Verified on beta (develop branch)
81555959-1b982a00-93a7-11ea-9f17-3da32eb5b64a
Screenshot 2020-05-12 at 3 13 17 PM

@lakshmiathreya lakshmiathreya added the P1 Urgent (resolve within 24 hours) label May 12, 2020
@SathyaJayabal SathyaJayabal added this to the v0.32.4 milestone May 13, 2020
@sandhiyakavi
Copy link
Collaborator

Verified in Production Env. Working as Expected.

@sandhiyakavi sandhiyakavi added Prod Env Environment and removed Beta Env Environment labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizrrodrigues luizrrodrigues

Labels
P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.32.4
Development

No branches or pull requests
4 participants
@luizrrodrigues @lakshmiathreya @sandhiyakavi @SathyaJayabal