Skip to content

Marathon Match Provisional Score: Ignore All unknown review types #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SathyaJayabal opened this issue May 15, 2020 · 0 comments
Open

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented May 15, 2020

In API calls that get submissions (i.e. https://api.topcoder.com/v5/submissions?challengeId=30120970&page=1&perPage=500), you'll see a review array. The app needs to check the typeID to determine the review type. The scores posted on the leaderboard should not be the typeID that maps to AV Scan. You'll notice some submissions have 1 review record while others have multiple review records. The app needs to inspect them to make sure it's the correct one to display.

The app must ignore all unknown review types.

Also when checking for the review types, the review type ID must not be hardcoded.
The community app should look up the reviewType of Virus Scan at the /v5/reviewTypes endpoint and ignore all reviews of that type's Id.

#4336 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant