Skip to content

[$80] SSF: When DataScience filter is removed, it is not showing right results #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nithyaasworld opened this issue Jul 1, 2019 · 74 comments

Comments

@nithyaasworld
Copy link
Collaborator

  1. Go to https://beta-community-app.topcoder.com/challenges
  2. Turn off Data Science filter and check

Actual:
It displays only 3 results and that too under the section "Open for registration"

However, When only Design filter is turned off (Dev and DS filter in On), it fetches right results.

Expected:
It should display all the sections like "My challenges", "Open for registration", etc with right number of results.

image

@nithyaasworld nithyaasworld added P2 Important (resolve within 3 days) Performance labels Jul 1, 2019
@nithyaasworld
Copy link
Collaborator Author

@sushilshinde This one seems to be new one too. Last time, I tested for about 2 hours and I did not see these issues.

@sushilshinde
Copy link
Collaborator

ok

@sushilshinde sushilshinde added P1 Urgent (resolve within 24 hours) and removed P2 Important (resolve within 3 days) labels Jul 1, 2019
@ThomasKranitsas ThomasKranitsas removed their assignment Jul 2, 2019
@ThomasKranitsas ThomasKranitsas changed the title SSF: When DataScience filter is removed, it is not showing right results [$80] SSF: When DataScience filter is removed, it is not showing right results Jul 2, 2019
@ThomasKranitsas
Copy link
Contributor

@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors open for pickup

PR on ’ssf-merged-to-new-develop’ branch

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30094926 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30094926 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@mhikeo mhikeo self-assigned this Jul 2, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30094926 has been updated - it has been assigned to mhykol.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

@mhikeo what's the status here?

@mhikeo
Copy link

mhikeo commented Jul 3, 2019

hi @ThomasKranitsas. I'm unable to replicate this issue. Btw, I think fix for #2698 removed the logic for Design, Development & Data Science filtering.

@codeMinter
Copy link
Contributor

Hi @ThomasKranitsas I can give this a try ?

@mhikeo
Copy link

mhikeo commented Jul 3, 2019

@gurmeetb you may take it

@codeMinter codeMinter assigned codeMinter and unassigned mhikeo Jul 3, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30094926 has been updated - it has been assigned to gurmeetb.

This is an automated message for thomaskranitsas via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@mhikeo i guess that logic was not properly working because it was unecessarily appending subtracks for which filter is not applied, hence subtracks were concated, and request parameter string was not correct.

I hope i have not missed anything major in that.

@ThomasKranitsas can you please review that

@ThomasKranitsas
Copy link
Contributor

@PrakashDurlabhji are you saying you fixed this in #2710 ?

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097459 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097459 has been updated - it has been assigned to rashmi73.

This is an automated message for lazybaer via Topcoder X

@nithyaasworld
Copy link
Collaborator Author

@rashmi73 @sushilshinde

I tested the scenario given in this ticket description. I find that "My challenges" section is not displayed after removing the DataScience filter however I see the right panel a count of 8 for "My Challenges".

This issue is still present.

Also it took 40 seconds to load the results when DS filter is turned off.

@rashmi73
Copy link
Contributor

@nithyaasworld just now I tested on production that my challenges can be seen perfectly even If I remove DS filter.

can you please confirm whether I am looking at perfect branch?

@rashmi73
Copy link
Contributor

@nithyaasworld I guess main requirement of issue that incorrect items are shown is already resolved.

@sushilshinde

@nithyaasworld
Copy link
Collaborator Author

@rashmi73 It is NOT on production. It is about the SSR Fixes. I am not sure which branch it is.

I tested the scenario given in this ticket description. I find that "My challenges" section is not displayed after removing the DataScience filter however I see the right panel a count of 8 for "My Challenges".

Seems like the issue is not always reproducible. It was reproducible yesterday and NOT reproducible in the morning today and again reproducible now. Please find the screenshot below.

image

@rashmi73
Copy link
Contributor

@sushilshinde can we close this now? PR for this issue was merged with I explaining a long discussion.
@nithyaasworld

@rashmi73
Copy link
Contributor

@sushilshinde waiting for this.

@nithyaasworld request you to help me by notifying sushilshinde to comment on this issue. thanks

@nithyaasworld
Copy link
Collaborator Author

@rashmi73 can you please share me the PR link?

As per my last testing results, we had some issue

@rashmi73
Copy link
Contributor

@nithyaasworld here is PR link #2718

which was merged and working fine on that respective branch, after that I guess branch was merged to some other branch and finally to production

@rashmi73
Copy link
Contributor

@nithyaasworld any updates on above?

@sushilshinde

@rashmi73
Copy link
Contributor

@nithyaasworld request you once again to please notify @sushilshinde via slack to please comment here.

@rashmi73
Copy link
Contributor

@Oanh-and-only-Oanh is it possible for you to help me on this along with @sushilshinde for closing this. it is pending since long time. thank you

@rashmi73
Copy link
Contributor

@ThomasKranitsas even you used to take followup this ticket, hence requesting you too to take some action it or atleast notify @sushilshinde , to close it.
@jmgasper

@rashmi73
Copy link
Contributor

@sushilshinde thanks, will check payment for this ticket too by EOD today

@rashmi73
Copy link
Contributor

@sushilshinde payment is not reflected in pacts yet. can you please confirm once again thanks

@crazyk07
Copy link

crazyk07 commented Jan 9, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097459

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

@rashmi73 this is done

FYI... @rootelement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants