issue 2696 fix

[rashmi73]

No description provided.

[ThomasKranitsas]

@rashmi73 @sushilshinde tested locally on dev and I'm facing an issue. When I open the challenge listings page and then turn off, let's say, Data Science track, it gets stuck in calling the API but it's not showing anything. It just keeps loading more and more data without actually showing anything.

[ThomasKranitsas]

[ThomasKranitsas]

Finally displayed the data after making 210+ requests with an offset of 4700 🤔

[rashmi73]

@ThomasKranitsas is it related to my changes?

I guess it should be present even before my PR.

kindly confirm.

[ThomasKranitsas]

Checking...

[sushilshinde]

@rashmi73 @ThomasKranitsas if it does exist before this PR please confirm on

https://beta-community-app.topcoder.com/challenges

[rashmi73]

@sushilshinde yes checking

[sushilshinde]

@rashmi73 please update

[rashmi73]

@sushilshinde @ThomasKranitsas it is working fine on https://beta-community-app.topcoder.com/challenges

also locally on my machine my PR was behaving perfectly,
I will test it once again on my local machine to confirm once again.
or else topcoder-react-lib, unnecesarily increasing offset on few combinations.

In an hour will update you.

[ThomasKranitsas]

@rashmi73 can I get an update, please? This is kinda urgent

[rashmi73]

@ThomasKranitsas sorry for late actively on this

[rashmi73]

@sushilshinde @ThomasKranitsas @nithyaasworld
I analyzed complete scenario what happened in #2698 and what I did, and why offset goes till 4500 in my this PR.

this offset issue till 4500 is neither introduced by mine or prakash PR which is already merged.

1. In [$80] SSF: It shows incorrect results for some combination of filters #2698 , Prakash raised PR to solve it, which removed code of @mhikeo , that PR was https://github.com/topcoder-platform/community-app/pull/2710/files which is merged, though it solved 2698 but broke other scenario. so before that PR was merged, mhikeo code already had this loading issue of offset=4500 present (but then mhikeo code also did not cover other scenario due to which combination of filters did not work), prakash PR removed that code and PR merged.

2. so now prakash code deployed on https://beta-community-app.topcoder.com, and there is no loading issue but one scenario failed.

3. now i took [$80] SSF: When DataScience filter is removed, it is not showing right results #2696 issue, i reverted what prakash did, so now i am on mhikeo code, which has loading issue, and to make all scenario work, i added mine minor code to handle all scenarios and mine current PR is raised .

4. so now https://beta-community-app.topcoder.com wont show loading offset=4500 issue, but mine PR will show loading offset issue because mhikeo code is also present as i modified and added few lines.

5. To verify my above claim, I removed mine modification and just ran whatever was present in mhikeo code(so now prakash code is not present) , so this loading offset=4500 is still present.

6. I also analyzed which offsett reaches 4500, and i feel it is due to code in topcoder-react-lib at https://github.com/topcoder-platform/topcoder-react-lib/blob/master/src/actions/challenge-listing.js#L52 not sure how much this affects, but surely problem is due to this file code as there is recursion in getAll function.

7.I could have surely handled this loading offset=4500 scenario but I am confused how this code flows.

I feel mine code should be merged to atleast satisfy the requirements of this combination of filters issue.

waiting for feedback

[ThomasKranitsas]

@sushilshinde the above report looks correct to me. I think we can merge this one and create a new ticket for the offset issue.

Thoughts?