Skip to content

[$50]Comment out blog component and calls #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Nov 20, 2019 · 22 comments
Closed

[$50]Comment out blog component and calls #3459

sushilshinde opened this issue Nov 20, 2019 · 22 comments
Assignees
Labels
P0 Critical (resolve within 4 hours) tcx_Assigned tcx_FixAccepted

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented Nov 20, 2019

  1. Search for api/proxy-get?url in the community app repo
  2. Comment out related components and calls in the app

It is P0, take it if you can submit in 4 hours or I will revoke the issue.

Use https://github.com/topcoder-platform/community-app/tree/hot-fix for PR

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@sushilshinde sushilshinde added tcx_OpenForPickup P0 Critical (resolve within 4 hours) labels Nov 20, 2019
@crazyk07
Copy link

Contest https://www.topcoder-dev.com/challenges/30107318 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30107320 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30107320 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30107320 has been updated - it has been assigned to anonymousjaggu.

This is an automated message for crazyk via Topcoder X

@anonymousjaggu anonymousjaggu removed their assignment Nov 20, 2019
@rashmi73 rashmi73 self-assigned this Nov 20, 2019
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30107320 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

@sushilshinde PR #3462

@cwdcwd
Copy link
Contributor

cwdcwd commented Nov 20, 2019

after reviewing at the code, fails to actually address the security issue which is this.

the community app allows for unfettered internal access by proxying calls through the application
this is a pretty ridiculous thing to do and I’m not sure why this was ever introduced, tbh, but the code issue is not the RSS feeds but the proxying that the RSS feeds utilize

testing on dev shows that this issue is not resolved as well
@rashmi73 @ThomasKranitsas see above mentioned line of code

@Oanh-and-only-Oanh
Copy link

Disabling the search UI on PROD in the meantime. @sushilshinde

@rashmi73
Copy link
Contributor

@cwdcwd @sushilshinde I am confused as what exactly is remaining now?

  1. Do I need to completely comment out the code at

    server.use(

  2. or just I need to remove "checkAuthorizationHeader" argument at

    server.use(

I guess requirements were met as mentioned in issue description.

Kindly confirm above so I immediately raise another PR.

@Oanh-and-only-Oanh
Copy link

@rashmi73, this issue and ticket are no longer relevant. Thank you for your work on this. Closing out the ticket and will process your payment. :)

@rashmi73
Copy link
Contributor

@sushilshinde no paid label on it?

@rashmi73
Copy link
Contributor

@Oanh-and-only-Oanh @sushilshinde payments are not reflecting in pacts yet, can you please confirm once again? thanks

@sushilshinde
Copy link
Collaborator Author

sushilshinde commented Nov 22, 2019

Commented endpoint as well

23392a2

and now

https:///community-app-assets/api/proxy-get?url=https%3A%2F%2Fwww.topcoder.com%2Fblog%2Ffeed%2F

should not work, which is expected

@rashmi73
Copy link
Contributor

@sushilshinde can we please complete the payment process nowitself? rather delaying it if everything is completed thank you

@sushilshinde
Copy link
Collaborator Author

@rashmi73 let me know if payment processed EOD today

@rashmi73
Copy link
Contributor

@sushilshinde thanks, but can we please also take a look at #2696, because PR was merged in the code and working well

@rashmi73
Copy link
Contributor

@sushilshinde payment is not reflected in pacts yet. can you please confirm once again thanks

@sushilshinde
Copy link
Collaborator Author

@rashmi73 payment is not reflected in both the tickets?

if that is the case please open a ticket with support

@rashmi73
Copy link
Contributor

@sushilshinde yes payment is not reflected for both tickets, mailing to support with url of both issues

@rashmi73
Copy link
Contributor

@sushilshinde I received a mail from support which is guiding you to go to these both links:
https://www.topcoder.com/direct/contest/detail.action?projectId=30094926

https://www.topcoder.com/direct/contest/detail.action?projectId=30107320

and assign me (rashmi73) for payment, because there are multiple people on above challenge hence need to select correct person.

@sushilshinde
Copy link
Collaborator Author

@rashmi73 @RiteshTC I will create a separate payment ticket.

I will remove payment information from these two tickets.

@rashmi73
Copy link
Contributor

rashmi73 commented Jan 9, 2020

@sushilshinde I hope payment for this will be done too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical (resolve within 4 hours) tcx_Assigned tcx_FixAccepted
Projects
None yet
Development

No branches or pull requests

7 participants