Remove Deposit Requirement for Custom Role

[wdprice]

When a user submits a custom role request, do not include the cost of that resource in the deposit amount, and do not show it to the end user on the checkout page:

Revised design when the user has a normal role and custom role in the "cart": https://marvelapp.com/prototype/89c7i66/screen/82013112/handoff

Revised design when the user only has custom roles in the "cart": https://marvelapp.com/prototype/89c7i66/screen/82043216/handoff

[yoution]

@wdprice @nikolay83 we should set the price to 0, or we need to hide the custom role?

when can you provide the design only has custom roles?

[wdprice]

If it makes implementation easier we can set the Custom Role price to $0. The redesigned "No Match" page removes the pricing display as well, so this could be an option.

…

On Wed, Sep 15, 2021 at 5:02 AM yoution ***@***.***> wrote: @wdprice <https://github.com/wdprice> @nikolay83 <https://github.com/nikolay83> we should set the price to 0, or we need to hide the custom role? [image: image] <https://user-images.githubusercontent.com/3863914/133403781-55a479ff-b3fa-4d58-bfba-d83660884912.png> when can you provide the design only has custom roles? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#504 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABN4IYN5LEJMZ3SEVC2CCFLUCBOJ3ANCNFSM5EASVRCQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[sdgun]

@yoution If the user sets a title on the Job description page, we still show the deposit amount for the custom role on the checkout page.

2021-09-16_12-44-47.mp4

[sdgun]

Verified in Dev.

[sdgun]

@wdprice In the design I see this page https://marvelapp.com/prototype/89c7i66/screen/82043216/handoff which we haven't implemented yet. Are we going to have a separate ticket for this?

[wdprice]

@sdgun - that design is the one was was marked as TBD in the initial design. I have updated the parent ticket.

CC: @nikolay83

[sdgun]

@wdprice Thanks. Just FYI, if the user only selects a custom role, there is no way to submit in the current implementation since the amount is 0.

[wdprice]

The point of the new design is to allow them to submit custom role only.

[sdgun]

We have not implemented this part yet "Revised design when the user only has custom roles in the "cart":", so submitting only custom roles is not possible @nikolay83

[sdgun]

@maxceem 'when the user(external) only has custom roles in the "cart"', they cannot proceed with the payments since we have changed the custom role amount to 0 in this ticket. The reason for this is we haven't implemented the second part of the requirement:

Revised design when the user only has custom roles in the "cart": https://marvelapp.com/prototype/89c7i66/screen/82043216/handoff

[maxceem]

TODO:

• If the total amount is 0 then show this page as per this design https://marvelapp.com/prototype/89c7i66/screen/82043216/handoff
• we have to set agree checkmark to make Confirm button active
• when we click Confirm show loading indicator somehow and send request to create a Team
• after Team is created, redirect to the Team page
• if error happens show red toastr with error and stay on the same page, so user can click Confirm again and try to send request again

@yoution would you like to handle this?
Payment: $40

[yoution]

@maxceem please assign to me

[maxceem]

@yoution I've assigned it to you. Please, ignore that bot unassigned you.

[yoution]

@maxceem do we need to update the title?

[maxceem]

@yoution no, let's keep it the same as per design.

[maxceem]

@yoution works as per local testing, passing for QA.

@sdgun this is ready for testing on DEV as per #504 (comment).

[sdgun]

@yoution @maxceem The title is different from the design, is this intentional?

[maxceem]

@sdgun Hmm, it was like that before this fix already for 3 months. I'm not sure if this is intentional or no, but I guess if nobody asked to change during this time, it's better to keep the current text confirm your request.

[maxceem]

@yoution paid via https://www.topcoder.com/challenges/db03928d-4a7b-42bf-8d18-a1094d2e6afa

[SathyaJayabal]

@sdgun ,

verified on safari/mac

[sdgun]

Verified in prod

Custom role with an existing role:

Only custom role: