[$30] The Deposit amounts are not calculated for newly added roles

[sdgun]

Steps
Add a new role from admin app with rates
Go to Intake app and select this role(log in from an external user)
Proceed to checkout page and see the deposit amounts

Actual behaviour
The Deposit amounts are not calculated for newly added roles

Expected behavior
The Deposit amounts should be calculated for newly added roles too

CC @maxceem

[maxceem]

@yoution would you like to handle this?

• Previously you've implemented this Remove Deposit Requirement for Custom Role #504 and to detect custom role you are using presence of imageUrl see https://github.com/topcoder-platform/taas-app/pull/508/files#diff-9fbd1eb4ca64c828127931cfca30ce30075247f3eba801674a4a8ebb319a6e72
• But we may create non-custom roles without image in TaaS Admin, like Test role 1
• Can we use some other way to detect custom roles?

[yoution]

@maxceem please assign to me

[maxceem]

@sdgun this was fixed on DEV and ready for QA.

PS: basically, this is a side effect of the fix for #504 so these kind of the same issue.

[maxceem]

@yoution found one issue of this solution during QA #529.

[yoution]

@maxceem I think I can not reproduce the issue

[maxceem]

@yoution did you try clicking pay $1000? because the issue happens after we try to pay.

[yoution]

@maxceem the payment amount is 1000? what do you mean?

[sdgun]

@yoution This issue only happens when you have a custom role(no matching role in our app) is submitted. And in both flows(external/internal users)

You can find the details in #529

[yoution]

@maxceem please ignore, I know the issue

[maxceem]

UPDATE: please ignore this report

@yoution also, I'm not sure why, but it started showing me price when I create a customer role using job description:

Steps to reproduce:

1. Clear all roles in storage so there are no roles saved.

2. Click "Create New Team"

3. Select "Describe the Work"

4. Enter title: "test", and text: angular jsp jfs node

   

5. Choose "jsp" only

   

6. Click "continue", "continue"

7. Enter Team Name and click Submit:

   

8. It shows custom role prize $1200, but as I understand it has to show 0 in this case:

   

[maxceem]

@yoution please ignore issue report above #525 (comment).

I guess it was cache issue, it works good in the incognito mode.

[yoution]

@maxceem please review

[maxceem]

@sdgun the #529 was fixed and ready for QA.

[sdgun]

This issue is fixed, amounts are calculated accurately.

[maxceem]

@yoution paid by https://www.topcoder.com/challenges/a39f7862-e3e7-4bf1-9cda-481f29ec5bda

[sdgun]

Verified in Prod