This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix: issue #504 #522
Merged
fix: issue #504 #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Oct 23, 2021
There was a problem hiding this comment.
@yoution generally works good, but I'd like to make some improvements.
-
There are some mismatches with design:
-
At the moment you've added new block to
PaymentFormbut Payment Form by name suppose to only contain Payment Form, not text with some rules.Could we instead create a new component for this, and then include it inside of the payment form when amount is 0 here https://github.com/topcoder-platform/taas-app/blob/dev/src/routes/CreateNewTeam/pages/CreateTaasPayment/index.jsx#L164 or something like that.
Does it make sense?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxceem please review