This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix(roles): roles page bugs #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `modalError` of the previous operation was still being displayed even after closing & opening the modal again. * This fix resets the `modalError` each time it re-opened. Addresses https://github.com/topcoder-platform/taas-app/issues/423
* Fix a typo in the "Successfully craeted the role." message of role creation notification. * Replace `craeted` -> `created` Addresses https://github.com/topcoder-platform/taas-app/issues/422
* Fix a bug with the `IntegerField` controls of the `RoleForm`, that was occurring when user trying to increase/decrease a number field which initially has `null`. * This was causing `NaN` values in the field. * This fix starts `IntegerField` controls with `0`, in case the user is trying to increase/decrease a `null` field. Addresses https://github.com/topcoder-platform/taas-app/issues/421
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
modalErrorof the previous operation was still being displayedeven after closing & opening the modal again.
This fix resets the
modalErroreach time it re-opened.Addresses topcoder-platform/taas-app#423
Fix a typo in the "Successfully craeted the role." message
of role creation notification.
Replace
craeted->createdAddresses topcoder-platform/taas-app#422
NaNrate values in the RoleFormFix a bug with the
IntegerFieldcontrols of theRoleForm,that was occurring when user trying to increase/decrease
a number field which initially has
null.This was causing
NaNvalues in the field.This fix starts
IntegerFieldcontrols with0,in case the user is trying to increase/decrease a
nullfield.Addresses topcoder-platform/taas-app#421