Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Niche rate cannot be set from Taas Admin for existing roles which do not have a niche rate #109

Closed
sdgun opened this issue Aug 3, 2021 · 2 comments
Closed

Niche rate cannot be set from Taas Admin for existing roles which do not have a niche rate #109

sdgun opened this issue Aug 3, 2021 · 2 comments
Labels
bug Something isn't working P2 QA Pass on Dev
Milestone
mfe-taas-admin-ap...

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 3, 2021

Steps

Go to TAAS Admin >> Roles
Click on update link on an existing role which does not have niche rate(ex- .Net Engineer)
Expand Rates section and try to increase the rate in Niche field

Shows 'NAN'

Niche.rate.update.mp4
cagdas001 referenced this issue in cagdas001/micro-frontends-taas-admin-app Aug 3, 2021
@cagdas001
fix(roles): NaN rate values in the RoleForm
870b4d5 
* Fix a bug with the `IntegerField` controls of the `RoleForm`,
  that was occurring when user trying to increase/decrease
  a number field which initially has `null`.
* This was causing `NaN` values in the field.
* This fix starts `IntegerField` controls with `0`,
  in case the user is trying to increase/decrease a `null` field.

Addresses https://github.com/topcoder-platform/taas-app/issues/421
@sdgun
Copy link
Collaborator Author

sdgun commented Aug 4, 2021

Verified in Dev.

2021-08-04_15-36-56.mp4

@SathyaJayabal SathyaJayabal transferred this issue from topcoder-archive/topcoder-platform-taas-app Aug 16, 2021
@sdgun sdgun added this to the mfe-taas-admin-app-v1.1 milestone Aug 16, 2021
@sdgun sdgun added bug Something isn't working P2 QA Pass on Dev labels Aug 16, 2021
@sdgun
Copy link
Collaborator Author

sdgun commented Aug 16, 2021

This cannot be verified in prod since all existing roles have niche rates.

@sdgun sdgun closed this as completed Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working P2 QA Pass on Dev
Projects
None yet
Milestone
mfe-taas-admin-app-v1.1
Development

No branches or pull requests
1 participant
@sdgun