Skip to content

Updated Formik testing example, added a missing parameter #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated Formik testing example, added a missing parameter #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/example-formik.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ import { Formik, Field, Form } from 'formik'
const sleep = ms => new Promise(r => setTimeout(r, ms))

export const MyForm = ({ onSubmit }) => {
const handleSubmit = async values => {
const handleSubmit = async (values, formikBag) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, could you point to forkik documentation for this? I couldn't find it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the Formik doc for the onSubmit callback? If so then this is the doc - https://formik.org/docs/api/formik#onsubmit-values-values-formikbag-formikbag--void--promiseany

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to revert #692.

You probably don't want to expose the formik bag anyway.

await sleep(500)
onSubmit(values)
onSubmit(values, formikBag)
}

return (
Expand Down