Update example-formik.md #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onSubmit has two arguments and we need to ignore the second one. (https://formik.org/docs/api/formik#onsubmit-values-values-formikbag-formikbag--void--promiseany) If we do not do this then we will get an error: ``` expect(jest.fn()).toHaveBeenCalledWith(...expected) - Expected + Received {"email": "[email protected]", "password": "password2398"}, + {"resetForm": [Function anonymous], "setErrors": [Function anonymous], "setFieldError": [Function anonymous], "setFieldTouched": [Function anonymous], "setFieldValue": [Function anonymous], "setFormikState": [Function anonymous], "setStatus": [Function anonymous], "setSubmitting": [Function anonymous], "setTouched": [Function anonymous], "setValues": [Function anonymous], "submitForm": [Function anonymous], "validateField": [Function anonymous], "validateForm": [Function anonymous]}, ```
eps1lon
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Thanks!
I thought jest would default to ignoring excess args. But it does indeed fail if not every arg is asserted on: https://codesandbox.io/s/winter-dream-g87iv?file=/src/index.test.js.
eps1lon
added a commit
to eps1lon/testing-library-docs
that referenced
this pull request
Jun 29, 2021
This reverts commit e8524e8.
|
We're reverting this change in #876 We didn't expose the formik bag to begin with. The assertion is only needed if you do pass the formik bag to |
eps1lon
added a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onSubmit has two arguments and we need to ignore the second one. (https://formik.org/docs/api/formik#onsubmit-values-values-formikbag-formikbag--void--promiseany)
If we do not do this then we will get an error: