Skip to content

Updated Formik testing example, added a missing parameter #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HouCoder
Copy link

This PR forgot to add the second onSubmit parameter in the example code, which causes the testing to always fail.

  ● rendering and submitting a basic Formik form

    expect(jest.fn()).toHaveBeenCalledWith(...expected)

    - Expected
    + Received

      {"email": "[email protected]", "firstName": "John", "lastName": "Dee"},
    - Anything,

    Number of calls: 1

@@ -14,9 +14,9 @@ import { Formik, Field, Form } from 'formik'
const sleep = ms => new Promise(r => setTimeout(r, ms))

export const MyForm = ({ onSubmit }) => {
const handleSubmit = async values => {
const handleSubmit = async (values, formikBag) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, could you point to forkik documentation for this? I couldn't find it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the Formik doc for the onSubmit callback? If so then this is the doc - https://formik.org/docs/api/formik#onsubmit-values-values-formikbag-formikbag--void--promiseany

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to revert #692.

You probably don't want to expose the formik bag anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants