Skip to content

Rules are not found in release 1.1.1 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jannisg opened this issue Nov 4, 2019 · 10 comments
Closed

Rules are not found in release 1.1.1 #10

jannisg opened this issue Nov 4, 2019 · 10 comments
Labels

Comments

@jannisg
Copy link

jannisg commented Nov 4, 2019

With my .eslintrc.js file as follows:

module.exports = {
  extends: [
    'plugin:testing-library/react',
    'plugin:jest-dom/recommended',
  ],
}

I am getting an error (for each rule) of

error  Definition for rule 'XXX' was not found

where XXX refers to all of the rules from this plugin (prefer-checked, prefer-enable-disable, and prefer-required)


Downgrading my eslint-plugin-jest-dom to version 1.1.0 fixes this issue and linting works as expected.

@benmonro
Copy link
Member

benmonro commented Nov 4, 2019

@gnapse can you look into this? I think the auto generated thing may be causing an issue here

@gnapse
Copy link
Member

gnapse commented Nov 4, 2019

Not sure why you ask me, as I really have no idea about the auto generated thing. A quick search in the PRs suggests we should involve @nickmccurdy in the conversation, given his contribution in #4.

@benmonro
Copy link
Member

benmonro commented Nov 4, 2019

Oops sorry. Picked the wrong name from the drop down. My apologies

@nickserv
Copy link
Member

nickserv commented Nov 4, 2019

What's your version of requireindex? You can check with npm ls requireindex or yarn why requireindex. If it's at least 1.2.0 this should work, in which case it's an issue with publishing the package. Otherwise it may be a bug in #4.

@gnapse
Copy link
Member

gnapse commented Nov 4, 2019

Oops sorry. Picked the wrong name from the drop down. My apologies

No problem. Glad to be involved anyway.

@nickserv
Copy link
Member

nickserv commented Nov 4, 2019

Whoops, looks like I forgot to add the package name prefix to the rules in #4, sorry about that. I can confirm that this issue is fixed in 1.1.2, and I'll make a fixed version of #4.

nickserv added a commit to nickserv/eslint-plugin-jest-dom that referenced this issue Nov 4, 2019
nickserv added a commit to nickserv/eslint-plugin-jest-dom that referenced this issue Nov 4, 2019
nickserv added a commit to nickserv/eslint-plugin-jest-dom that referenced this issue Nov 4, 2019
@jannisg
Copy link
Author

jannisg commented Nov 4, 2019

Thanks @nickmccurdy :)

I have just upgraded my project to use 1.1.2 and can confirm this has been fixed. 🎉

Different timezone so just got back into this, FWIW, my requireindex version was indeed at 1.2.0.

@jannisg jannisg closed this as completed Nov 4, 2019
benmonro pushed a commit that referenced this issue Nov 6, 2019
* Revert "Revert "Autogenerate recommended config""

This reverts commit 0512ce6.

* Add missing jest-dom prefix to config (fixes #10)
@benmonro
Copy link
Member

benmonro commented Nov 6, 2019

🎉 This issue has been resolved in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmonro
Copy link
Member

benmonro commented Nov 6, 2019

@jannisg actually 1.1.2 was a revert of 1.1.1. 1.1.3 is the actual fix, would you mind giving it a spin to ensure it's working for you?

@jannisg
Copy link
Author

jannisg commented Nov 12, 2019

@benmonro Upgraded my project to 1.1.3 and it's all working as expected. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants