fix: Add missing jest-dom prefix to config (fixes #10) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickmccurdy looks like there's some conflicts, prob related to the revert I did here: #12 can you also make sure the docs that were reverted there are re-added? |
|
I'm not sure what the easiest way around this is, since git doesn't know that I want to merge the old branch again even though master has reverted some of its commits. Should I revert #12 or rebase the original PR onto master again? |
|
yeah that or a rebase....
…On Mon, Nov 4, 2019 at 10:25 AM Nick McCurdy ***@***.***> wrote:
I'm not sure what the easiest way around this is, since git doesn't know
that I want to merge the old branch again even though master has reverted
some of its commits. Should I revert #12
<#12> or
rebase the original PR onto master again?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=AADBPBDBLA73OMJGGPZIWEDQSBSJ3A5CNFSM4JIXJK6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDAHPNQ#issuecomment-549484470>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADBPBEFLWPNSF52S6U4Z7TQSBSJ3ANCNFSM4JIXJK6A>
.
--
Ben Monro
Software Developer
|
nickserv
force-pushed
the
autogenerate-recommended-config
branch
3 times, most recently
from
bccfece to
55a7618
Compare
nickserv
force-pushed
the
autogenerate-recommended-config
branch
from
167ad83 to
10b5ac4
Compare
|
I think I fixed the merge, so this should be working now. Should I add any specific Semantic Pull Request prefix? |
|
@nickmccurdy yes please. i think |
|
i will have to test it later tonight though |
nickserv
changed the title
|
Updated title |
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.