Skip to content

Commit 0512ce6

Browse files
authored
Revert "Autogenerate recommended config"
1 parent 0e8b357 commit 0512ce6

File tree

5 files changed

+14
-62
lines changed

5 files changed

+14
-62
lines changed

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ Then configure the rules you want to use under the rules section.
3434

3535
```json
3636
{
37-
"rules": {}
37+
"rules": {
38+
"jest-dom/prefer-checked": "error",
39+
"jest-dom/prefer-enabled-disabled": "error",
40+
"jest-dom/prefer-required": "error"
41+
}
3842
}
3943
```
4044

lib/index.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,13 @@ let requireIndex = require('requireindex');
1717
// import all rules in lib/rules
1818
module.exports.rules = requireIndex(__dirname + '/rules');
1919

20-
module.exports.generateRecommendedConfig = rules => {
21-
return Object.entries(rules).reduce(
22-
(memo, [name, rule]) =>
23-
rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo,
24-
{}
25-
);
26-
};
27-
2820
module.exports.configs = {
2921
recommended: {
3022
plugins: ['jest-dom'],
31-
rules: module.exports.generateRecommendedConfig(module.exports.rules),
23+
rules: {
24+
'jest-dom/prefer-checked': 'error',
25+
'jest-dom/prefer-enabled-disabled': 'error',
26+
'jest-dom/prefer-required': 'error',
27+
},
3228
},
3329
};

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"generate-readme-table": "node build/generate-readme-table.js"
1616
},
1717
"dependencies": {
18-
"requireindex": "~1.2.0"
18+
"requireindex": "~1.1.0"
1919
},
2020
"devDependencies": {
2121
"eslint": "^6.6.0",
@@ -30,4 +30,4 @@
3030
"node": ">=0.10.0"
3131
},
3232
"license": "ISC"
33-
}
33+
}
+1-40
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,3 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`should have all the rules 1`] = `
4-
Object {
5-
"prefer-checked": Object {
6-
"create": [Function],
7-
"meta": Object {
8-
"docs": Object {
9-
"category": "jest-dom",
10-
"description": "prefer toBeChecked over checking attributes",
11-
"recommended": true,
12-
"url": "prefer-checked",
13-
},
14-
"fixable": "code",
15-
},
16-
},
17-
"prefer-enabled-disabled": Object {
18-
"create": [Function],
19-
"meta": Object {
20-
"docs": Object {
21-
"category": "jest-dom",
22-
"description": "prefer toBeDisabled or toBeEnabled over checking attributes",
23-
"recommended": true,
24-
"url": "prefer-enabled-disabled",
25-
},
26-
"fixable": "code",
27-
},
28-
},
29-
"prefer-required": Object {
30-
"create": [Function],
31-
"meta": Object {
32-
"docs": Object {
33-
"category": "jest-dom",
34-
"description": "prefer toBeRequired over checking properties",
35-
"recommended": true,
36-
"url": "prefer-required",
37-
},
38-
"fixable": "code",
39-
},
40-
},
41-
}
42-
`;
3+
exports[`should have all the rules 1`] = `Object {}`;

tests/index.test.js

+1-10
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
1-
const { rules, generateRecommendedConfig, configs } = require('../lib/index');
1+
const { rules } = require('../lib/index');
22

33
it('should have all the rules', () => {
44
expect(rules).toMatchSnapshot();
55
});
6-
7-
it('should have a recommended config with recommended rules', () => {
8-
expect(
9-
generateRecommendedConfig({
10-
good: { meta: { docs: { recommended: true } } },
11-
bad: { meta: { docs: { recommended: false } } },
12-
})
13-
).toEqual({ good: 'error' });
14-
});

0 commit comments

Comments
 (0)