Merge the main branch into package #4977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURL documentation (https://curl.se/libcurl/c/CURLMOPT_TIMERFUNCTION.html) explicitly says that the timer should be one-time. We basically have to follow CURL requests for setting, resetting and disarming such timers. Current logic eventually leaves a 1ms repeating timer forever, because CURL assumes it fires once, and may not ask us to remove it explicitly. Also, being used as request timeout trigger, this timer also has no sense to be repeated.
Extends socket lifetime enough to let DispatchSource cancel properly. Also prevents from creating new DispatchSources while other are in the middle of cancelling. Also includes tests (see swiftlang#4854 for test details).
Fixes swiftlang/swift#73532. On Windows, socket handles in a `fd_set` are not represented as bit flags as in Berkeley sockets. While we have no `fd_set` dynamic growth in this implementation, the `FD_SETSIZE` defined as 1024 in `CoreFoundation_Prefix.h` should be enough for majority of tasks.
…patchsource-close
[Windows] Use `fd_set` according to Winsock2 specifics
* Add `data(from:delegate:)` method. * Add async URLSession methods --------- Co-authored-by: ichiho <[email protected]>
[wasm] Do not set permissions in `Data.write`
jmschonfeld
approved these changes
Jun 10, 2024
| @@ -666,6 +682,231 @@ internal extension URLSession { | |||
| } | |||
| } | |||
|
|
|||
| fileprivate struct Lock<State>: @unchecked Sendable { | |||
There was a problem hiding this comment.
Doesn't have to be a part of this PR, but maybe we should expose FoundationEssentials.LockedState as @_spi to avoid inventing yet another lock type
There was a problem hiding this comment.
I think we'll soon be able to use Mutex anyway.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate latest updates from
mainintopackage.