Fix test_webSocket hang #4973
Merged
Fix test_webSocket hang #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
etcwilde
reviewed
Jun 6, 2024
etcwilde
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM
Cherry-picking this back to 5.10 gets me past the hanging websocket test on Fedora40.
The macOS failure (dyld[95291]: Symbol not found: _swift_getTypeByMangledNameInContext2) is known. The OS on the test runners is too old for the latest standard library.
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Jun 7, 2024
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the test server sends a close message shortly after sending a pong, the connection might close before our task handles the pong and calls its completion handler. In this case, the pong completion handler is never called, so
try await task.sendPing()hangs indefinitely.This PR cleans up
pongCompletionHandlerson error/close and minimally fixes the test to allow the case where the server closes the connection before the pong is handled.