Add async URLSession methods #4970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Jun 5, 2024
jrflat
added a commit
to jrflat/swift-corelibs-foundation
that referenced
this pull request
Jun 6, 2024
* Add `data(from:delegate:)` method. * Add async URLSession methods --------- Co-authored-by: ichiho <[email protected]>
trunk-io bot
pushed a commit
to Tyler-Keith-Thompson/Afluent
that referenced
this pull request
Mar 19, 2025
With [this PR](swiftlang/swift-corelibs-foundation#4970), the async/await URLSession functions are now available on other OS's, but only in swift 6. Updates `URLSessionAdditions.swift` to also check for swift 6, and enable these urlsession -> afluent bridge functions when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @b1ackturtle for providing the foundation of this work in #4705!
This PR implements the remaining async
URLSessionmethods and theURLSessionTask.delegateproperty, allowing a delegate to be set in the async methods (or in a non-async context before resumption).URLSessionTask.delegatereturns the explicitly set delegate if present, otherwise returns the session delegateas? URLSessionTaskDelegate. It's now used wherever we previously casted the session delegate toURLSessionTaskDelegate. To accompany this change, functions inextension URLSessionTaskDelegate(which are called if not implemented by the task's delegate) now check if the session's delegate implements it and call the session's delegate if that's the case.