break: remove css option

[lukeed]

Closes #146

As discussed in Discord, we'll just pitch CSS contents into Rollup. Anything else (transforming, actually getting the CSS contents written into a file, etc) needs to be handled by another plugin now.

RIP #136 #140

[lukeed]

Thanks for approval, but not convinced this is done quite yet. Right now a css.map is inlined automatically:

rollup-plugin-svelte/index.js

Line 115 in fc24f87

compiled.css.code += `\n/*# sourceMappingURL=${compiled.css.map.toUrl()} */`;

I think that should be removed since it'll be included in the load output when found, and the consumer of the virtual file will decide what to do with it.

[benmccann]

I'm not totally sure I understand the issue you're talking about @lukeed, but it seems separable and unrelated to the css option, so I wonder if we should go ahead with this PR and possibly do that in a follow up?

[benmccann]

Actually, one last thought I had on this PR - we should probably default emitCss to true, right? I would expect that we're going to set emitCss: true in both sveltejs/template and in sveltejs/sapper-template and most users will be setting it to true in a corresponding fashion, so that's probably the better default since it will be the most commonly used value.

[lukeed]

we should probably default emitCss to true, right?

Yes I think so – since we also recommended against inlining CSS inside the JS code.

[benmccann]

Ok, I updated this PR to stop inlining the sourcemap and default emitCss to true. I'm happy to merge this now if you are

[lukeed]

Think we're done here too. Thanks @benmccann !

[nolanlawson]

Sorry if this is the wrong place to ask this question, but what is the recommended replacement for css: true (i.e. inlining the CSS in the JS)? I'm reading the changelog and rollup-plugin-css-only, but I only see how to extract into a bundle.css file, not retain the old CSS-in-JS behavior.

[lukeed]

Use emitCss: false, though like before it's not recommended