You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #145 (and previously too, tbh) I feel like it might make more sense to consolidate emitCss and css into one option.
It could be a single extractCss option.
false – sets compilerOptions.css: false, resulting in inlined CSS
true – similar to emitCss: true1
function – sets compilerOptions.css: false, and uses custom CssWriter to produce a single CSS output.
Prior Art
This would follow what rollup-plugin-postcss has been doing, and feels very intuitive. We can follow it more closely, and allow boolean | string values only, where string uses a CssWriter function internally (the 90% default anyway).
1 Our emitCss should be emitting CSS files individually only. Right now, they're given importd lines but are still concatenated into the single file that CssWriter produces anyway (bug).
The text was updated successfully, but these errors were encountered:
While working on #145 (and previously too, tbh) I feel like it might make more sense to consolidate
emitCss
andcss
into one option.It could be a single
extractCss
option.false
– setscompilerOptions.css: false
, resulting in inlined CSStrue
– similar toemitCss: true
1function
– setscompilerOptions.css: false
, and uses customCssWriter
to produce a single CSS output.Prior Art
This would follow what
rollup-plugin-postcss
has been doing, and feels very intuitive. We can follow it more closely, and allowboolean | string
values only, wherestring
uses a CssWriter function internally (the 90% default anyway).The text was updated successfully, but these errors were encountered: