break: use compilerOptions for svelte.compile config
#145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show warning on presence of non-plugin option - Closes #144
benmccann
reviewed
Oct 22, 2020
benmccann
approved these changes
Oct 22, 2020
Closed
msmolens
added a commit
to msmolens/treetop
that referenced
this pull request
Dec 4, 2020
Update rollup config for rollup-plugin-svelte 7.0.0. In particular, move the 'dev' and 'css' options for the Svelte compiler to the 'compilerOptions' key. See sveltejs/rollup-plugin-svelte#145.
msmolens
added a commit
to msmolens/treetop
that referenced
this pull request
Dec 4, 2020
Update rollup config for rollup-plugin-svelte 7.0.0. In particular, move the 'dev' and 'css' options for the Svelte compiler to the 'compilerOptions' key. See sveltejs/rollup-plugin-svelte#145.
msmolens
added a commit
to msmolens/treetop
that referenced
this pull request
Dec 4, 2020
Update rollup config for rollup-plugin-svelte 7.0.0. In particular, move the 'dev' and 'css' options for the Svelte compiler to the 'compilerOptions' key. See sveltejs/rollup-plugin-svelte#145.
rdela
referenced
this pull request
in rdela/kokodokai
Jan 1, 2021
see sveltejs/sapper-template#289 appears to require svelte 3.30.1 or higher
philipp-tailor
added a commit
to philipp-tailor/svelte_sidebar
that referenced
this pull request
Feb 13, 2021
... after breaking update. Re-aligned the configuration as demonstrated [here](https://github.com/sveltejs/template/blob/5b1135c286f7a649daa99825a077586655051649/rollup.config.js#L48). The breaking changes were: * [removing CSS extraction](sveltejs/rollup-plugin-svelte#147) * [nesting compiler options in key](sveltejs/rollup-plugin-svelte#145)
philipp-tailor
added a commit
to philipp-tailor/svelte_sidebar
that referenced
this pull request
Feb 13, 2021
* build(deps-dev): bump rollup-plugin-svelte from 6.1.1 to 7.1.0 Bumps [rollup-plugin-svelte](https://github.com/sveltejs/rollup-plugin-svelte) from 6.1.1 to 7.1.0. - [Release notes](https://github.com/sveltejs/rollup-plugin-svelte/releases) - [Changelog](https://github.com/sveltejs/rollup-plugin-svelte/blob/master/CHANGELOG.md) - [Commits](sveltejs/rollup-plugin-svelte@v6.1.1...v7.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * chore: re-configure rollup-plugin-svelte ... after breaking update. Re-aligned the configuration as demonstrated [here](https://github.com/sveltejs/template/blob/5b1135c286f7a649daa99825a077586655051649/rollup.config.js#L48). The breaking changes were: * [removing CSS extraction](sveltejs/rollup-plugin-svelte#147) * [nesting compiler options in key](sveltejs/rollup-plugin-svelte#145) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Philipp Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
compilerOptionssynchronization step from #144Decided to kick the bucket on whether or not to auto-load
svelte.config.jsfor another day.