breaking: version requirements #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- matches Rollup 2.x requirement
Merged
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]and beyond from now on[email protected]and beyond from now on (fix(types): extendCompileOptionsinterface directly #126 (comment))And defines an
engines.noderequirement for the first time. We're matching Rollup 2.x's restriction – and Node 10+ allows us to start usingasync, if nothing else.The primary purpose of this PR is maintainer health/sanity, because supporting multi-year-old versions "just because" is not sustainable. Semver allows us to safely move on by cutting a new major release. Users stuck on old versions can continue to use the old version of
rollup-plugin-svelte& others.In the short-term, this unblocks #126