Skip to content

Feature: add ability to pass in specific version of svelte #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

saibotsivad
Copy link

This will resolve #123 by adding support for passing in a specific version of the Svelte compiler (more discussion on that issue).

My skills at TypeScript are sorely lacking, so I'm not confident that I added definitions correctly.

Copy link
Member

@antony antony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntactical change

@lukeed lukeed requested a review from antony October 19, 2020 23:04
@lukeed
Copy link
Member

lukeed commented Oct 19, 2020

Made the requested changes. Also made it so that the Svelte interface, which is now using version, is require-friendly. You can pass in individual keys, as was originally intended, or use require('svelte') directly. I updated the README to reflect this. @saibotsivad If you don't mind taking a peek at this again, would be great 🙇

@lukeed
Copy link
Member

lukeed commented Oct 19, 2020

OK. We have decided that this will be backported as a 6.1.0 release... and then removed in the upcoming 7.0 release. The reasoning is that start with 7.0, we're dropping support for old Node/Rollup/Svelte versions. We have to do this for sanity, and semver allows us to do so (see #138)

Once I get the 6.x branch up to date, I will update this base branch & revert the rebase that I applied to this PR.

@lukeed lukeed changed the base branch from master to 6.x October 19, 2020 23:39
@lukeed lukeed requested review from benmccann and Conduitry October 19, 2020 23:46
@lukeed lukeed merged commit 65fbfc7 into sveltejs:6.x Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple Svelte versions?
5 participants