Skip to content

Feature: add ability to pass in specific version of svelte #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ export default {

// let Rollup handle all other warnings normally
handler(warning);
},

// Pass in a specific version of Svelte, e.g. if you use
// npm aliases to install multiple versions you can import
// a specific version:
// import svelte1 from 'svelte1' // aliased version of [email protected]
svelte: {
compile: svelte1.compile,
preprocess: svelte1.preprocess,
major_version: 1
}
})
]
Expand Down
11 changes: 11 additions & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ declare class CssWriter {
toString(): string;
}

interface Svelte {
compile: any;
preprocess: any;
major_version: number;
}

interface Options {
/**
* By default, all .svelte and .html files are compiled
Expand Down Expand Up @@ -80,6 +86,11 @@ interface Options {
*/
customElement?: boolean;

/**
* Pass in a specific version of Svelte.
*/
svelte?: Svelte;

/**
* let Rollup handle all other warnings normally
*/
Expand Down
17 changes: 12 additions & 5 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
const fs = require('fs');
const path = require('path');
const relative = require('require-relative');
const { version } = require('svelte/package.json');
const { createFilter } = require('rollup-pluginutils');
const { encode, decode } = require('sourcemap-codec');

const major_version = +version[0];
const pkg_export_errors = new Set();

const { compile, preprocess } = major_version >= 3
? require('svelte/compiler.js')
: require('svelte');
function loadDefaultSvelte() {
const { version } = require('svelte/package.json');

const major_version = +version[0];

const { compile, preprocess } = major_version >= 3
? require('svelte/compiler.js')
: require('svelte');

return { compile, preprocess, major_version };
}

function sanitize(input) {
return path
Expand Down Expand Up @@ -110,6 +116,7 @@ class CssWriter {
}

module.exports = function svelte(options = {}) {
const { compile, preprocess, major_version } = options.svelte || loadDefaultSvelte();
const filter = createFilter(options.include, options.exclude);

const extensions = options.extensions || ['.html', '.svelte'];
Expand Down