Skip to content

Chore: Attach GitHub Action for CI #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2020
Merged

Chore: Attach GitHub Action for CI #139

merged 7 commits into from
Oct 19, 2020

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Oct 19, 2020

Imports the ci.yml file I use for any of my modules that deal with the filesystem.

Runs Node 10.x, 12.x, 14.x versions on the three OS options: ubuntu, windows, macOS

The verbose on: config is to skip CI when a commit and/or PR only changes the readme.md, for example.
AFAIK, there's a shortcut like on: [push, pull_request] but not a shortcut for having both events share the same config.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not much of a Github Actions expert, but this lgtm

@benmccann
Copy link
Member

Oops. Looks like it failed:

Error: Unable to resolve action actions/setup-node@v2, unable to find version v2

@lukeed
Copy link
Member Author

lukeed commented Oct 19, 2020

Yeah I'm gunna be playing with it. Wasn't a direct 1:1 copy of what I typically use. Sorry for noise :D

@lukeed lukeed merged commit b57aed4 into master Oct 19, 2020
@lukeed lukeed deleted the chore/actions branch October 19, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants