Fixed bug with styled-system to prevent undefined properties (issue #94) #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand what's happened it's just strange for me that we need to check this inside that method function and not before. It check also only for undefined and not for null results. |
|
Yeah I see what you mean. I could add the null check. |
andreruffert
added a commit
to andreruffert/vue-styled-components
that referenced
this pull request
Jun 26, 2020
Prevents generating `undefined` style properties e.g
`{ fontSize: '16px', fontFamily: undefined }`
The above props would generate the following styles:
```
font-size: 16px;
font-family: undefined;
```
The new feature is filtering false props before generating and injecting the styles. The new styles now look something like this:
```
font-size: 16px;
```
More details: styled-components#102
This was referenced Jun 26, 2020
andreruffert
added a commit
to andreruffert/vue-styled-components
that referenced
this pull request
Jul 6, 2020
Prevents generating `undefined` style properties e.g
`{ fontSize: '16px', fontFamily: undefined }`
The above props would generate the following styles:
```
font-size: 16px;
font-family: undefined;
```
The new feature is filtering false props before generating and injecting the styles. The new styles now look something like this:
```
font-size: 16px;
```
More details: styled-components#102
andreruffert
added a commit
to andreruffert/vue-styled-components
that referenced
this pull request
Jul 30, 2020
Prevents generating `undefined` style properties e.g
`{ fontSize: '16px', fontFamily: undefined }`
The above props would generate the following styles:
```
font-size: 16px;
font-family: undefined;
```
The new feature is filtering false props before generating and injecting the styles. The new styles now look something like this:
```
font-size: 16px;
```
More details: styled-components#102
liqueflies
added a commit
that referenced
this pull request
Nov 28, 2020
|
Solved merging #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix issue #94
Describe the bug
When using vue-styled-components with styled-system version 5+ and you add styled-system utilities (space for example), you can see that in the CSS of the element you'll have every property of space with a value of undefined. I tested with the latest version 4 (4.2.4) of styled-system and there is no bug.
To Reproduce
With styled-system version 4, no bug
https://codesandbox.io/s/vue-styledsystem-gl9z8
With styled-system version 5, with the bug
https://codesandbox.io/s/vue-styled-system-v3r91
Expected behavior
Since in Vue we need to define all prop types, the css ends up with lots of undefined values. There should be no undefined properties when these properties have no value. When a property has a value, it should end up with the correct value in the style - this part currently works.
Screenshots
Here you can see the undefined properties