Skip to content

.attrs feature not present #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milesbeyond opened this issue Feb 6, 2019 · 4 comments
Closed

.attrs feature not present #68

milesbeyond opened this issue Feb 6, 2019 · 4 comments

Comments

@milesbeyond
Copy link

Code:

const Button = styled.button.attrs({
  title: 'TEST'
})`
  background: green
`;

Error:

Uncaught TypeError: vue_styled_components__WEBPACK_IMPORTED_MODULE_2__.default.button.attrs is not a function

I'm aware that this Vue port of Styled-Components is not fully featured, but would like to understand where/if this stands on the feature roadmap? It's a pretty killer feature IMO, if not the killer feature, and I miss it :(

Can someone shed some light onto this, please?

@liqueflies
Copy link
Collaborator

liqueflies commented Apr 2, 2019

Hello,
thank you for the interest on the repo and sorry for late reply but I am very busy at the moment and no one is helping me on that.

Please, remember that vue-styled-components is a proof of concept, because it not depends on the main repo, but code is cloned and each new feature have to be re-implemented, so it's not an adapter of the main repo, obviously for a main repo limitation.

you can read this discussion starting from here to understand the pain.

If this issue on main-repo still remain it's very hard to get updatd with all the new feature.

Also main repo is well maintained by a lot of developers, here I'm alone and I wold appreciate new maintainers that will help me keeping update this. :)

At the moment is very difficult to me get into new feature, I can review other PR's for clean code integration and bug-fixing :)

Thank you so much,
Lorenzo

@zaxozhu
Copy link
Contributor

zaxozhu commented Aug 9, 2019

Created a PR #83

@wellitongervickas
Copy link

wellitongervickas/batmovies@73d5efe
wellitongervickas/batmovies@73d5efe#diff-d6f575eb4fa640ebe7a8c06e74ef47b5

I just import in others layouts/*.vue to reuse my global styles

@liqueflies
Copy link
Collaborator

Solved merging #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants