Skip to content

styled-system 5+ with vue-styled-components - undefined css properties #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carldufourm opened this issue Oct 28, 2019 · 2 comments
Closed

Comments

@carldufourm
Copy link

Describe the bug
When using vue-styled-components with styled-system version 5+ and you add styled-system utilities (space for example), you can see that in the CSS of the element you'll have every property of space with a value of undefined. I tested with the latest version 4 (4.2.4) of styled-system and there is no bug.

To Reproduce

  • Start a Vue project with packages "vue-styled-components" & "styled-system" (version 5+, this is important)
  • Create a styled component with prop types defined
  • Put that styled component in a view
  • Witness that all of it's prop types are in the CSS with undefined value

With styled-system version 4, no bug
https://codesandbox.io/s/vue-styledsystem-gl9z8

With styled-system version 5, with the bug
https://codesandbox.io/s/vue-styled-system-v3r91

Expected behavior
Since in Vue we need to define all prop types, the css ends up with lots of undefined values. There should be no undefined properties when these properties have no value. When a property has a value, it should end up with the correct value in the style - this part currently works.

Screenshots
Here you can see the undefined properties
Screen Shot 2019-10-25 at 8 47 54 AM

@carldufourm
Copy link
Author

@liqueflies I opened pull request #102 to fix this bug.

@liqueflies
Copy link
Collaborator

Solved merging #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants