Move Conversion-related functionality to MappingR2dbcConverter. #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Mar 5, 2019
| @@ -77,7 +78,12 @@ public R2dbcRepositoryFactory(DatabaseClient databaseClient, | |||
| this.databaseClient = databaseClient; | |||
| this.mappingContext = mappingContext; | |||
| this.dataAccessStrategy = dataAccessStrategy; | |||
| this.converter = new MappingR2dbcConverter(new BasicRelationalConverter(mappingContext)); | |||
|
|
|||
| if (dataAccessStrategy instanceof DefaultReactiveDataAccessStrategy) { | |||
There was a problem hiding this comment.
I don't like the check against a specific implementation.
I'd rather have an interface (e.g. WithConverter) which other implementations can use to denote that they use a R2dbcConverter inside which we can extract.
mp911de
force-pushed
the
issue/gh-61
branch
2 times, most recently
from
bd6374f to
65634ee
Compare
All conversion functionality is now pulled together into MappingR2dbcConverter. Introduce OutboundRow to provide mapping between column names and settable values. Remove identifier from SettableValue.
|
That's fixed now. |
schauder
pushed a commit
that referenced
this pull request
Mar 5, 2019
All conversion functionality is now pulled together into MappingR2dbcConverter. Introduce OutboundRow to provide mapping between column names and settable values. Remove identifier from SettableValue. Original pull request: #62.
|
That's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All conversion functionality is now pulled together into
MappingR2dbcConverter.Introduce
OutboundRowto provide mapping between column names and settable values. Remove identifier fromSettableValue.Related ticket: #61.