Skip to content

#56 - Use Statement Builder API for SELECT statements #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Feb 26, 2019

No description provided.

@mp911de mp911de requested a review from schauder February 26, 2019 12:51
@schauder schauder self-assigned this Mar 5, 2019
@mp911de
Copy link
Member Author

mp911de commented Mar 5, 2019

I think this one requires a different approach, once #62 is done. Not quite happy with how the code is distributed.

schauder pushed a commit that referenced this pull request Mar 5, 2019
schauder added a commit that referenced this pull request Mar 5, 2019
Replaced calls to `SqlRenderer.render(.)` with `SqlRenderer.toString(.)`.
And code formatting.

Original pull request: #66.
@schauder
Copy link
Contributor

schauder commented Mar 5, 2019

That's merged.

I replaced the no invalid call to SqlRenderer.render with SqlRenderer.toString leaving the introduction of a RenderContext to a future change.

@schauder schauder closed this Mar 5, 2019
@mp911de mp911de deleted the issue/gh-56-statement-builder branch March 22, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants