Add converters for simple type projections #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Feb 22, 2019
|
|
||
| @Override | ||
| public Boolean convert(Row row) { | ||
| return (Boolean) row.get(0); |
There was a problem hiding this comment.
Use row.get(0, Boolean.class) to avoid downcasting.
This also applies for all other calls (except for theRowToNumberConverterFactory).
There was a problem hiding this comment.
awesome. I will do this refactorings and create a test for the converters.
uaihebert
force-pushed
the
feature/add-row-converters
branch
from
c1b350b to
61f2966
Compare
|
hellp @mp911de PR is updated. |
|
Thanks a lot. The code looks good. Care to add a bit of Javadoc? Have a look into the other store modules that provide similar converters for inspiration. |
uaihebert
force-pushed
the
feature/add-row-converters
branch
from
61f2966 to
5bdaafe
Compare
|
done. Let me know if there is anything else that I should do here. |
|
Looks good. We now should wait until #62 is merged to avoid further merge conflicts. |
mp911de
added
type: enhancement
mp911de
removed
the
status: blocked
mp911de
changed the title
mp911de
added a commit
that referenced
this pull request
Mar 10, 2019
Rename RowDataConverter to R2dbcConverters. Introduce R2dbcSimpleTypeHolder. Apply custom conversions check in MappingR2dbcConverter. Extend tests. Original pull request: #65.
mp911de
approved these changes
Mar 10, 2019
|
That's merged and polished now. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial solution for #41