#30 - Add custom conversion support to write array-typed values. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EntityRowMapper now passes-thru values for Collection-like types such as array. Arrays are supported by Postgres. Original pull request: #22.
Add author tag. Add unit test for EntityRowMapper.
We now support custom conversions via R2dbcCustomConversions. Custom conversions introduces simple types that depend on the used dialect. Custom conversions and simple types are held in RelationalConverter and MappingContext. Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns. Related tickets: #22, #26.
schauder
requested changes
Dec 4, 2018
src/main/java/org/springframework/data/r2dbc/dialect/PostgresDialect.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java
Show resolved
Hide resolved
src/test/java/org/springframework/data/r2dbc/function/convert/EntityRowMapperUnitTests.java
Show resolved
Hide resolved
src/test/java/org/springframework/data/r2dbc/function/convert/EntityRowMapperUnitTests.java
Show resolved
Hide resolved
Minor formatting. Add suggestions. Update src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java Co-Authored-By: mp911de <[email protected]>
|
I applied your suggestions @schauder and pushed the improvements. |
schauder
requested changes
Dec 5, 2018
src/main/java/org/springframework/data/r2dbc/dialect/PostgresDialect.java
Outdated
Show resolved
Hide resolved
| ArrayColumns arrayColumns = PostgresDialect.INSTANCE.getArraySupport(); | ||
|
|
||
| assertThatThrownBy(() -> arrayColumns.getArrayType(getClass())).isInstanceOf(IllegalArgumentException.class); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| @Test // gh-30 | |
| public void shouldRejectNestedCollections() { | |
| ArrayColumns arrayColumns = PostgresDialect.INSTANCE.getArraySupport(); | |
| assertThatThrownBy( | |
| () -> arrayColumns.getArrayType(List.class) | |
| ).isInstanceOf(IllegalArgumentException.class); | |
| } |
The added test fails but I think it should because we don't apply the conversion to arrays recursively.
There was a problem hiding this comment.
I'll add the test and remove List from simple types. While Postgres supports n-dimensional array, the driver does not support that option so it's safe for now to only support 1-dimensional arrays without recursion.
src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java
Outdated
Show resolved
Hide resolved
Introduce ArrayColumns type to encapsulate Dialect-specific array support. Apply array conversion for properties that do not match the native array type. Add integration tests for Postgres array columns.
schauder
pushed a commit
that referenced
this pull request
Dec 7, 2018
Add author tag. Add unit test for EntityRowMapper. Original pull request: #31.
schauder
pushed a commit
that referenced
this pull request
Dec 7, 2018
We now support custom conversions via R2dbcCustomConversions. Custom conversions introduces simple types that depend on the used dialect. Custom conversions and simple types are held in RelationalConverter and MappingContext. Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns. Related tickets: #22, #26. Original pull request: #31.
schauder
added a commit
that referenced
this pull request
Dec 7, 2018
Minor formatting. Add suggestions. Update src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java Co-Authored-By: mp911de <[email protected]> Original pull request: #31.
schauder
pushed a commit
that referenced
this pull request
Dec 7, 2018
Introduce ArrayColumns type to encapsulate Dialect-specific array support. Apply array conversion for properties that do not match the native array type. Add integration tests for Postgres array columns. Original pull request: #31.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support custom conversions via R2dbcCustomConversions. Custom conversions introduces simple types that depend on the used dialect. Custom conversions and simple types are held in RelationalConverter and MappingContext.
Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns.
Supersedes PR #22.
Related tickets: #22, #26, #30.