Skip to content

Add support for Custom Conversions for array-types #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Dec 3, 2018 · 1 comment
Closed

Add support for Custom Conversions for array-types #30

mp911de opened this issue Dec 3, 2018 · 1 comment
Assignees
@schauder
Milestone
1.0 M1

Comments

@mp911de
Copy link
Member

mp911de commented Dec 3, 2018

We should add R2dbcCustomConversions to distinguish between entity types and non-entity types.
Right now, String[] is considered an entity as well as List and Collection. For Postgres, we would like to read and write array types.
@mp911de mp911de self-assigned this Dec 3, 2018
@mp911de mp911de mentioned this issue Dec 3, 2018
Closed
mp911de added a commit that referenced this issue Dec 3, 2018
@mp911de
#30 - Add custom conversion support.
8d2bd6c 
We now support custom conversions via R2dbcCustomConversions. Custom conversions introduces simple types that depend on the used dialect. Custom conversions and simple types are held in RelationalConverter and MappingContext.

Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns.

Related tickets: #22, #26.
mp911de added a commit that referenced this issue Dec 3, 2018
@mp911de
#30 - Prepare issue branch.
c238bb2
@mp911de mp911de mentioned this issue Dec 3, 2018
Closed
@mp911de mp911de assigned schauder and unassigned mp911de Dec 3, 2018
@mp911de mp911de added this to the 1.0.0 M1 milestone Dec 4, 2018
schauder pushed a commit that referenced this issue Dec 4, 2018
@mp911de @schauder
#30 - Add custom conversion support.
ccadfad 
We now support custom conversions via R2dbcCustomConversions. Custom conversions introduces simple types that depend on the used dialect. Custom conversions and simple types are held in RelationalConverter and MappingContext.

Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns.

Related tickets: #22, #26.
schauder pushed a commit that referenced this issue Dec 4, 2018
@mp911de @schauder
#30 - Prepare issue branch.
384f3b4
schauder added a commit that referenced this issue Dec 4, 2018
@schauder
#30 - Polishing.
9f7990d 
Minor formatting.
mp911de added a commit that referenced this issue Dec 5, 2018
@schauder @mp911de
#30 - Polishing.
299c0c5 
Minor formatting. Add suggestions.

Update src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java

Co-Authored-By: mp911de <[email protected]>
mp911de added a commit that referenced this issue Dec 5, 2018
@mp911de
#30 - Address review feedback.
d41957d 
Introduce ArrayColumns type to encapsulate Dialect-specific array support. Apply array conversion for properties that do not match the native array type. Add integration tests for Postgres array columns.
@mp911de mp911de changed the title Add support for Custom Conversions Add support for Custom Conversions for array-types Dec 5, 2018
mp911de added a commit that referenced this issue Dec 5, 2018
@mp911de
#30 - Address review feedback.
108dcf6
mp911de added a commit that referenced this issue Dec 7, 2018
@mp911de
#30 - Address review feedback.
b5c90d1 
Introduce ArrayColumns type to encapsulate Dialect-specific array support. Apply array conversion for properties that do not match the native array type. Add integration tests for Postgres array columns.
schauder pushed a commit that referenced this issue Dec 7, 2018
@mp911de @schauder
#30 - Add custom conversion support.
c357e5b 
We now support custom conversions via R2dbcCustomConversions.
Custom conversions introduces simple types that depend on the used dialect.
Custom conversions and simple types are held in RelationalConverter and MappingContext.

Simple types and conversions are used by DatabaseClient and repository support to properly apply registered converters and support native types such as array-columns.

Related tickets: #22, #26.
Original pull request: #31.
schauder added a commit that referenced this issue Dec 7, 2018
@schauder
#30 - Polishing.
be5383a 
Minor formatting. Add suggestions.

Update src/test/java/org/springframework/data/r2dbc/dialect/PostgresDialectUnitTests.java

Co-Authored-By: mp911de <[email protected]>

Original pull request: #31.
schauder pushed a commit that referenced this issue Dec 7, 2018
@mp911de @schauder
#30 - Address review feedback.
9f68352 
Introduce ArrayColumns type to encapsulate Dialect-specific array support.
Apply array conversion for properties that do not match the native array type.
Add integration tests for Postgres array columns.

Original pull request: #31.
@schauder
Copy link
Contributor

schauder commented Dec 7, 2018

Done.

@schauder schauder closed this as completed Dec 7, 2018
mp911de added a commit that referenced this issue May 17, 2019
@mp911de
#30 - Polishing.
5714709 
Fix custom converter documentation. Accept custom converters in DefaultReactiveDataAccessStrategy constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
None yet
Projects
None yet
Milestone
1.0 M1
Development

No branches or pull requests
2 participants
@schauder @mp911de