Add fluent update() and delete() operations to DatabaseClient and improve select() and insert(). #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support Criteria creation and mapping to express where conditions with a fluent API.
databaseClient.select().from("legoset")
.where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));
databaseClient.delete()
.from(LegoSet.class)
.where(Criteria.of("id").is(42055))
.then()
databaseClient.delete()
.from(LegoSet.class)
.where(Criteria.of("id").is(42055))
.fetch()
.rowsUpdated()
Document fluent API. Add fluent API for update. Introduce StatementMapper. Migrate Insert to StatementMapper. Refactoring and cleanup. Migrate Select to StatementMapper.
Fixed typos, formatting and minor errors in documentation.
schauder
requested changes
May 7, 2019
src/main/java/org/springframework/data/r2dbc/function/query/Criteria.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/r2dbc/function/query/Criteria.java
Show resolved
Hide resolved
| @@ -196,7 +207,7 @@ public InsertIntoSpec insert() { | |||
| * @throws IllegalStateException in case of no DataSource set | |||
| */ | |||
| protected ConnectionFactory obtainConnectionFactory() { | |||
| return connector; | |||
| return this.connector; | |||
There was a problem hiding this comment.
Is there a reason for using this. all over the place?
src/main/java/org/springframework/data/r2dbc/function/DefaultStatementFactory.java
Show resolved
Hide resolved
odrotbohm
added a commit
that referenced
this pull request
May 8, 2019
Incorporated feedback from review. Polished documentation and Javadoc. Minor code improvements restructuring for better readability. Removed unused methods types. Some polishing for compiler warnings. Original pull request: #106.
odrotbohm
pushed a commit
that referenced
this pull request
May 8, 2019
We now support Criteria creation and mapping to express where conditions with a fluent API.
databaseClient.select().from("legoset")
.where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));
databaseClient.delete()
.from(LegoSet.class)
.where(Criteria.of("id").is(42055))
.then()
databaseClient.delete()
.from(LegoSet.class)
.where(Criteria.of("id").is(42055))
.fetch()
.rowsUpdated()
Original pull request: #106.
odrotbohm
pushed a commit
that referenced
this pull request
May 8, 2019
Original pull request: #106.
odrotbohm
pushed a commit
that referenced
this pull request
May 8, 2019
Document fluent API. Add fluent API for update. Introduce StatementMapper. Migrate Insert to StatementMapper. Refactoring and cleanup. Migrate Select to StatementMapper. Original pull request: #106.
odrotbohm
pushed a commit
that referenced
this pull request
May 8, 2019
Fixed typos, formatting and minor errors in documentation. Original pull request: #106.
odrotbohm
added a commit
that referenced
this pull request
May 8, 2019
Incorporated feedback from review. Polished documentation and Javadoc. Minor code improvements restructuring for better readability. Removed unused methods types. Some polishing for compiler warnings. Original pull request: #106.
|
That's polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now provide fluent operations for all CRUD operations through a fluent interface.
We introduced
CriteriaandUpdateobjects to express filter conditions and to describe update assignments.We also removed
StatementFactoryin favor of aStatementMapper.StatementMapperaccepts statement specifications and maps these to dialec-specificPreparedOperations considering mapping-metadata.We also split documentation for R2DBC into parts for easier editing.
Depends on: #73.