Skip to content

Introduce PreparedOperation #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Mar 18, 2019 · 0 comments
Closed

Introduce PreparedOperation #73

mp911de opened this issue Mar 18, 2019 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
1.0 M2

Comments

@mp911de
Copy link
Member

mp911de commented Mar 18, 2019

We should introduce a PreparedOperation API in preparation to encapsulate SQL along with value bindings. This is required to migrate off String concatenation towards our Statement Builder API that generated statements and provides binding values.

A PreparedOperation should be able to be executed by DatabaseClient and should be created by a StatementFactory that considers Dialect-specifics and that is able to use the rendering component for statements.
@mp911de mp911de added this to the 1.0 M2 milestone Mar 18, 2019
mp911de added a commit that referenced this issue Mar 18, 2019
@mp911de
#73 - Prepare issue branch.
585f64c
mp911de added a commit that referenced this issue Mar 18, 2019
@mp911de
#73 - Introduce PreparedOperation.
ce90430 
We now encapsulate prepared operations from the StatementFactory within PreparedOperation that renders SQL and provides binding values.

StatementFactory supports SELECT/INSERT/UPDATE/DELETE statement creation considering Dialect-specific rendering.
StatementFactory replaces String-based statement methods in ReactiveDataAccessStrategy.

PreparedOperation<Update> operation = accessStrategy.getStatements().update(entity.getTableName(), binder -> {
	binder.bind("name", "updated value");
	binder.filterBy("id", SettableValue.from(42));
});

databaseClient.execute().sql(operation).then();
@mp911de mp911de added the type: enhancement A general enhancement label Mar 18, 2019
@mp911de mp911de mentioned this issue Mar 18, 2019
Open
mp911de added a commit that referenced this issue Mar 22, 2019
@mp911de
#73 - Prepare issue branch.
0a554d7
mp911de added a commit that referenced this issue Mar 22, 2019
@mp911de
#73 - Introduce PreparedOperation.
b99aa16 
We now encapsulate prepared operations from the StatementFactory within PreparedOperation that renders SQL and provides binding values.

StatementFactory supports SELECT/INSERT/UPDATE/DELETE statement creation considering Dialect-specific rendering.
StatementFactory replaces String-based statement methods in ReactiveDataAccessStrategy.

PreparedOperation<Update> operation = accessStrategy.getStatements().update(entity.getTableName(), binder -> {
	binder.bind("name", "updated value");
	binder.filterBy("id", SettableValue.from(42));
});

databaseClient.execute().sql(operation).then();
mp911de added a commit that referenced this issue Mar 22, 2019
@mp911de
#73 - Polishing.
4f72724 
Switch license header URLs to HTTPS.
@mp911de mp911de mentioned this issue Mar 22, 2019
Closed
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
#73 - Prepare issue branch.
75b6ede
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
#73 - Introduce PreparedOperation.
cd28c65 
We now encapsulate prepared operations from the StatementFactory within PreparedOperation that renders SQL and provides binding values.

StatementFactory supports SELECT/INSERT/UPDATE/DELETE statement creation considering Dialect-specific rendering.
StatementFactory replaces String-based statement methods in ReactiveDataAccessStrategy.

PreparedOperation<Update> operation = accessStrategy.getStatements().update(entity.getTableName(), binder -> {
	binder.bind("name", "updated value");
	binder.filterBy("id", SettableValue.from(42));
});

databaseClient.execute().sql(operation).then();
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
#73 - Polishing.
8dce8ad 
Switch license header URLs to HTTPS. Rebase onto master.
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#73 - Prepare issue branch.
226f178
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#73 - Introduce PreparedOperation.
4ee4e44 
We now encapsulate prepared operations from the StatementFactory within PreparedOperation that renders SQL and provides binding values.

StatementFactory supports SELECT/INSERT/UPDATE/DELETE statement creation considering Dialect-specific rendering.
StatementFactory replaces String-based statement methods in ReactiveDataAccessStrategy.

PreparedOperation<Update> operation = accessStrategy.getStatements().update(entity.getTableName(), binder -> {
	binder.bind("name", "updated value");
	binder.filterBy("id", SettableValue.from(42));
});

databaseClient.execute().sql(operation).then();
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#73 - Polishing.
e353197 
Switch license header URLs to HTTPS. Rebase onto master.
@mp911de mp911de mentioned this issue May 2, 2019
Closed
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - introduced alternative bind method.
71fea91
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - removed call to old bind.
f5d7791
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - code symmetry.
3e558ba
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - extracted ParameterbindingPreparedOperation.
7030d1c
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - minor code improvements.
605e52e
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - minor code improvements.
58bd298
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - disassembling.
a158c6b
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - removed old bind method from interface.
565faf5
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - changed method name according to review.
e13fcd7
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - extracted super class.
9b32943
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - separate Bindings class.
2804726
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - prepared various single bindings.
dcdd968
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - proper expanded single binding.
01d114d
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - always nice when code compiles.
7b57ff8
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - fixed an error.
71b81a1
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - fixed another error.
7f9c42c
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - added backup.
13690ea
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - moved bindings in constructor.
fa55f0e
schauder added a commit that referenced this issue May 6, 2019
@schauder
#73 - hacking - ExpandedBindings work as well.
2265c7f
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#73 - Introduce PreparedOperation.
ef2d885 
We now encapsulate prepared operations from the StatementFactory within PreparedOperation that renders SQL and provides binding values.

StatementFactory supports SELECT/INSERT/UPDATE/DELETE statement creation considering Dialect-specific rendering.
StatementFactory replaces String-based statement methods in ReactiveDataAccessStrategy.

PreparedOperation<Update> operation = accessStrategy.getStatements().update(entity.getTableName(), binder -> {
	binder.bind("name", "updated value");
	binder.filterBy("id", SettableValue.from(42));
});

databaseClient.execute().sql(operation).then();

Original pull request: #82.
mp911de pushed a commit that referenced this issue May 6, 2019
@schauder @mp911de
#73 - Polishing.
02e0cb5 
Original pull request: #82.
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#73 - Introduce BindTarget.
88945d7 
We now apply bindings to a BindTarget that can be overridden without the need to implement all Statement methods.

PreparedOperation no longer has a direct dependency on R2DBC Statement.

Original pull request: #82.
@mp911de mp911de self-assigned this May 6, 2019
@mp911de mp911de closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0 M2
Development

No branches or pull requests
1 participant
@mp911de