Skip to content

Add criteria API to create filter predicates #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Feb 20, 2019 · 0 comments
Closed

Add criteria API to create filter predicates #64

mp911de opened this issue Feb 20, 2019 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
1.0 M2

Comments

@mp911de
Copy link
Member

mp911de commented Feb 20, 2019

To make DatabaseClient's select() API more usable, we should introduce a Criteria API for row filtering. Right now, select statements build through DatabaseClient.select() are unfiltered and thus not usable for the majority of ad-hoc queries.

Having a Criteria API allows us to lay a foundation for update and delete DSL support.
@mp911de mp911de added the type: enhancement A general enhancement label Feb 20, 2019
@mp911de mp911de self-assigned this Mar 25, 2019
@mp911de mp911de added this to the 1.0 M2 milestone Mar 25, 2019
@mp911de mp911de mentioned this issue Apr 24, 2019
Closed
mp911de added a commit that referenced this issue Apr 30, 2019
@mp911de
#64 - Prepare issue branch.
3ab0594
mp911de added a commit that referenced this issue Apr 30, 2019
@mp911de
#64 - Add Criteria API.
3e47f11 
We now support Criteria creation and mapping to express where conditions with a fluent API.

databaseClient.select().from("legoset")
				.where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));
mp911de added a commit that referenced this issue Apr 30, 2019
@mp911de
#64 - Add criteria support to DatabaseClient.
c68cc27 
Move PreparedOperation to operation package.
mp911de added a commit that referenced this issue Apr 30, 2019
@mp911de
#64 - Add delete DSL support to DatabaseClient.
3215a24 
We now support DELETE queries using DatabaseClient's delete() DSL.

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.then()

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.fetch()
				.rowsUpdated()
mp911de added a commit that referenced this issue Apr 30, 2019
@mp911de
#64 - Add workaround for pagination.
ec86231 
In place until we migrate to Spring Data Relational dialects.
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Split documentation for R2DBC core into parts.
c1ff048
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - API polishing.
5c2b6dd
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Document fluent API.
08c3f87
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add fluent API for update. Introduce StatementMapper.
3cedd75
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Migrate Insert to StatementMapper.
2e6af4a
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Refactoring and cleanup.
cbac745
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Migrate Select to StatementMapper.
3d5c512
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Prepare issue branch.
3db82a2
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add Criteria API.
aa8c61a 
We now support Criteria creation and mapping to express where conditions with a fluent API.

databaseClient.select().from("legoset")
				.where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add criteria support to DatabaseClient.
8fc52bf 
Move PreparedOperation to operation package.
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add delete DSL support to DatabaseClient.
ce6a3c5 
We now support DELETE queries using DatabaseClient's delete() DSL.

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.then()

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.fetch()
				.rowsUpdated()
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add workaround for pagination.
398c968 
In place until we migrate to Spring Data Relational dialects.
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Split documentation for R2DBC core into parts.
f169205
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - API polishing.
3fc3f75
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Document fluent API.
fb5e0f2
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Add fluent API for update. Introduce StatementMapper.
9f343b0
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Migrate Insert to StatementMapper.
941ca39
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Refactoring and cleanup.
baf8d1d
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Migrate Select to StatementMapper.
dcc46de
mp911de added a commit that referenced this issue May 2, 2019
@mp911de
#64 - Last cleanups.
046cdc4
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#64 - Prepare issue branch.
a39d2eb
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#64 - Add Criteria API.
c4fc1e8 
We now support Criteria creation and mapping to express where conditions with a fluent API.

databaseClient.select().from("legoset")
				.where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.then()

databaseClient.delete()
				.from(LegoSet.class)
				.where(Criteria.of("id").is(42055))
				.fetch()
				.rowsUpdated()
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#64 - Split documentation for R2DBC core into parts.
92c89a7
mp911de added a commit that referenced this issue May 6, 2019
@mp911de
#64 - API polishing.
36da637 
Document fluent API. Add fluent API for update. Introduce StatementMapper. Migrate Insert to StatementMapper. Refactoring and cleanup. Migrate Select to StatementMapper.
schauder added a commit that referenced this issue May 7, 2019
@schauder
#64 - Polishing.
2ff58d8 
Fixed typos, formatting and minor errors in documentation.
odrotbohm added a commit that referenced this issue May 8, 2019
@odrotbohm
#64 - Polishing.
515a512 
Incorporated feedback from review. Polished documentation and Javadoc. Minor code improvements restructuring for better readability. Removed unused methods types. Some polishing for compiler warnings.

Original pull request: #106.
odrotbohm pushed a commit that referenced this issue May 8, 2019
@mp911de @odrotbohm
#64 - Add Criteria API.
fd4472a 
We now support Criteria creation and mapping to express where conditions with a fluent API.

databaseClient.select().from("legoset")
  .where(Criteria.of("name").like("John%").and("id").lessThanOrEquals(42055));

databaseClient.delete()
  .from(LegoSet.class)
  .where(Criteria.of("id").is(42055))
  .then()

databaseClient.delete()
  .from(LegoSet.class)
  .where(Criteria.of("id").is(42055))
  .fetch()
  .rowsUpdated()

Original pull request: #106.
odrotbohm pushed a commit that referenced this issue May 8, 2019
@mp911de @odrotbohm
#64 - Split documentation for R2DBC core into parts.
ff69a41 
Original pull request: #106.
odrotbohm pushed a commit that referenced this issue May 8, 2019
@mp911de @odrotbohm
#64 - API polishing.
774d2e8 
Document fluent API. Add fluent API for update. Introduce StatementMapper. Migrate Insert to StatementMapper. Refactoring and cleanup. Migrate Select to StatementMapper.

Original pull request: #106.
odrotbohm pushed a commit that referenced this issue May 8, 2019
@schauder @odrotbohm
#64 - Polishing.
361d801 
Fixed typos, formatting and minor errors in documentation.

Original pull request: #106.
odrotbohm added a commit that referenced this issue May 8, 2019
@odrotbohm
#64 - Polishing.
da53a9a 
Incorporated feedback from review. Polished documentation and Javadoc. Minor code improvements restructuring for better readability. Removed unused methods types. Some polishing for compiler warnings.

Original pull request: #106.
@odrotbohm odrotbohm assigned odrotbohm and unassigned odrotbohm May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0 M2
Development

No branches or pull requests
2 participants
@odrotbohm @mp911de