Skip to content

Fix alias detection in multi-line queries #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix alias detection in multi-line queries #2603

wants to merge 1 commit into from

Conversation

darinmanica
Copy link
Contributor

See #2563

  • [✓] You have read the Spring Data contribution guidelines.
  • [✓] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [✓] You submit test cases (unit or integration tests) that back your changes.
  • [✓] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2022
@darinmanica darinmanica mentioned this pull request Jul 22, 2022
Closed
@freafrea freafrea mentioned this pull request Sep 2, 2022
Closed
@agzamovr agzamovr mentioned this pull request Sep 13, 2022
Closed
gregturn pushed a commit that referenced this pull request Sep 28, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
91cd84e 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 28, 2022
@gregturn
Polishing.
f773701 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn
Copy link
Contributor

gregturn commented Sep 28, 2022 •
edited
Loading

Your test cases were folded into f773701. Thanks!

@gregturn gregturn closed this Sep 28, 2022
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
0dec0b0 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
7a6f534 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
1ae67c8 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
c116755 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn
Copy link
Contributor

Backported to 2.7.x. and 2.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darinmanica @gregturn @spring-projects-issues