Skip to content

Handle newlines in subquery detection #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle newlines in subquery detection #2557

wants to merge 1 commit into from

Conversation

freafrea
Copy link

@freafrea freafrea commented Jun 1, 2022

  • [V] You have read the Spring Data contribution guidelines.
  • [V] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [V] You submit test cases (unit or integration tests) that back your changes.
  • [V] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Added support for handling newlines in finding of subqueries. Changed . to match newlines in regex.

@freafrea freafrea changed the title New lines Handle newlines in subquery detection Jun 1, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 1, 2022
@freafrea
Copy link
Author

freafrea commented Jun 1, 2022

It is my first time adding a PR to spring related projects, so I am not sure I've followed all guidelines :)

@freafrea
Copy link
Author

freafrea commented Jun 13, 2022 •
edited
Loading

This issue is blocking my upgrade to spring boot 2.7.0. Is there anything I can do to help in merging this?

@freafrea freafrea mentioned this pull request Jul 13, 2022
Closed
4 tasks
@freafrea
Copy link
Author

freafrea commented Sep 2, 2022

@gregturn sorry for calling, but this issue blocks upgrading to newer spring boot versions. It is already fixed in at least three seperate PRs (this one, #2582, #2603).
I don't care which one you will merge, but could you please look into any of them?

@darinmanica darinmanica mentioned this pull request Sep 13, 2022
Closed
gregturn pushed a commit that referenced this pull request Sep 28, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
91cd84e 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 28, 2022
@gregturn
Polishing.
f773701 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn
Copy link
Contributor

The test cases from this PR were merged into f773701. Thanks!

@gregturn gregturn closed this Sep 28, 2022
@gregturn gregturn added this to the 3.0 RC1 (2022.0.0) milestone Sep 28, 2022
@gregturn gregturn self-assigned this Sep 28, 2022
@gregturn gregturn added type: bug A general bug in: query-parser Everything related to parsing JPQL or SQL and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 28, 2022
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
0dec0b0 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
7a6f534 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
gregturn pushed a commit that referenced this pull request Sep 29, 2022
@c-fraser @gregturn
Handle multiline subquery removal.
1ae67c8 
Closes #2582.
Related: #2563, #2557, #2603
gregturn added a commit that referenced this pull request Sep 29, 2022
@gregturn
Polishing.
c116755 
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn
Copy link
Contributor

Backported to 2.7.x. and 2.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregturn gregturn

Labels
in: query-parser Everything related to parsing JPQL or SQL type: bug A general bug
Projects
None yet
Milestone
3.0 RC1 (2022.0.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@freafrea @gregturn @spring-projects-issues