Skip to content

Handle multiline subquery removal #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

c-fraser
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@c-fraser c-fraser changed the title Handle multiline subquery removal. Handle multiline subquery removal Jun 28, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 28, 2022
@freafrea
Copy link

Hi, this looks like almost the same change as the one I've added previously :)
#2557
Do you know of any way of speeding up the acceptance? Already we have both reimplemented the same behaviour.

@edoswaldgo
Copy link

Thank you @c-fraser, @freafrea ! 👍 Hope the fix can be applied soon. We're encountering the issue because we format our queries with new lines.

@gregturn gregturn closed this in 91cd84e Sep 28, 2022
gregturn added a commit that referenced this pull request Sep 28, 2022
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn gregturn self-assigned this Sep 28, 2022
@gregturn gregturn added type: bug A general bug in: query-parser Everything related to parsing JPQL or SQL and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 28, 2022
@gregturn gregturn added this to the 3.0 RC1 (2022.0.0) milestone Sep 28, 2022
@c-fraser c-fraser deleted the issue/gh-2581 branch September 29, 2022 12:03
gregturn pushed a commit that referenced this pull request Sep 29, 2022
gregturn added a commit that referenced this pull request Sep 29, 2022
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
gregturn pushed a commit that referenced this pull request Sep 29, 2022
gregturn added a commit that referenced this pull request Sep 29, 2022
Also added more test cases from related pull requests.

Closes #2582.
Related: #2563, #2557, #2603
@gregturn
Copy link
Contributor

Backported to 2.7.x. and 2.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: query-parser Everything related to parsing JPQL or SQL type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants