Skip to content

Switching on compilation with parameter names breaks EclipseLink stored procedure tests #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schauder opened this issue Sep 14, 2021 · 0 comments
Closed

Switching on compilation with parameter names breaks EclipseLink stored procedure tests #2298

schauder opened this issue Sep 14, 2021 · 0 comments
Assignees
@mp911de
Labels
type: task A general task
Milestone
2.4.13 (2020.0.13)

Comments

@schauder
Copy link
Contributor

No description provided.

@mp911de mp911de added the type: task A general task label Sep 14, 2021
@mp911de mp911de added this to the 2.4.13 (2020.0.13) milestone Sep 14, 2021
mp911de added a commit that referenced this issue Sep 14, 2021
@mp911de
Disable parameter names for test compilation.
1b6c779 
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
mp911de added a commit that referenced this issue Sep 14, 2021
@mp911de
Disable parameter names for test compilation.
08d4e28 
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
2.4.13 (2020.0.13)
Development

No branches or pull requests
2 participants
@schauder @mp911de