Skip to content

Commit 08d4e28

Browse files
committed
Disable parameter names for test compilation.
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name. When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin. Closes: #2298 See also spring-projects/spring-data-build#1513
1 parent fd3aa69 commit 08d4e28

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

pom.xml

+17
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,22 @@
382382
</executions>
383383
</plugin>
384384

385+
<plugin>
386+
<artifactId>maven-compiler-plugin</artifactId>
387+
<executions>
388+
<execution>
389+
<id>java-test-compile</id>
390+
<phase>test-compile</phase>
391+
<goals>
392+
<goal>testCompile</goal>
393+
</goals>
394+
<configuration>
395+
<parameters>false</parameters>
396+
</configuration>
397+
</execution>
398+
</executions>
399+
</plugin>
400+
385401
<plugin>
386402
<groupId>io.starter</groupId>
387403
<artifactId>aspectj-maven-plugin</artifactId>
@@ -403,6 +419,7 @@
403419
<goals>
404420
<goal>compile</goal>
405421
</goals>
422+
<phase>process-classes</phase>
406423
</execution>
407424
</executions>
408425
<configuration>

0 commit comments

Comments
 (0)